This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Signed-off-by: GitHub <[email protected]>
tier4-autoware-public-bot
bot
force-pushed
the
sync-launch-files
branch
from
December 20, 2022 00:19
5b79b27
to
8b2379d
Compare
h-ohta
force-pushed
the
sync-launch-files
branch
from
December 20, 2022 02:12
18bc7c2
to
7afdee2
Compare
h-ohta
reviewed
Dec 20, 2022
@@ -4,116 +4,140 @@ | |||
<arg name="map_path" description="point cloud and lanelet2 map directory path"/> | |||
<arg name="vehicle_model" description="vehicle model name"/> | |||
<arg name="sensor_model" description="sensor model name"/> | |||
<arg name="vehicle_id" default="$(env VEHICLE_ID default)" description="vehicle specific ID"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h-ohta
reviewed
Dec 20, 2022
<arg name="vehicle_id" default="$(env VEHICLE_ID default)" description="vehicle specific ID"/> | ||
|
||
<!-- Optional parameters --> | ||
<arg name="rviz" default="true" description="launch rviz"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 20, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
h-ohta
reviewed
Dec 22, 2022
tkimura4
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This was referenced Dec 23, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipped
Added
Changed
Not changed
Deleted
Not found
Related Link
https://tier4.atlassian.net/browse/T4PB-24626