Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(behavior_path_planner): change pull over max_lateral_offset #670

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 29, 2022

Signed-off-by: kosuke55 [email protected]

PR Type

  • Improvement

Related Links

Description

change max_lateral_offset of pull_over 1.0 -> 0.5.
before this PR, the max lateral margin is 0.5 + 1.0 = 1.5 and this seems large.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kosuke55 kosuke55 merged commit 5895271 into awf-latest Dec 29, 2022
@kosuke55 kosuke55 deleted the feat/pull_over_max_lateral_offset branch December 29, 2022 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants