Skip to content

Commit

Permalink
Remove mention of Velodyne sensors in Hesai code (#100)
Browse files Browse the repository at this point in the history
`NebulaModelToHesaiModelNo` was explicitly handling Velodyne models, while it should really just handle everything that is `not Hesai` the same. Because of this, PR #77 and future sensor additions cause warnings in this piece of code (enum value XYZ not handled).

Co-authored-by: Maximilian Schmeller <[email protected]>
  • Loading branch information
mojomex and mojomex authored Nov 29, 2023
1 parent 71e7d0e commit 7e28d15
Showing 1 changed file with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3202,16 +3202,10 @@ int HesaiHwInterface::NebulaModelToHesaiModelNo(nebula::drivers::SensorModel mod
return 40;
case SensorModel::HESAI_PANDARAT128:
return 48;
case SensorModel::VELODYNE_VLS128:
case SensorModel::VELODYNE_HDL64:
case SensorModel::VELODYNE_VLP32:
case SensorModel::VELODYNE_VLP32MR:
case SensorModel::VELODYNE_HDL32:
case SensorModel::VELODYNE_VLP16:
case SensorModel::UNKNOWN:
// All other vendors and unknown sensors
default:
return -1;
}
return -1;
}
void HesaiHwInterface::SetTargetModel(int model) { target_model_no = model; }
void HesaiHwInterface::SetTargetModel(nebula::drivers::SensorModel model) { target_model_no = NebulaModelToHesaiModelNo(model); }
Expand Down

0 comments on commit 7e28d15

Please sign in to comment.