refactor(hesai_hw_interface): remove mention of Velodyne sensors in Hesai code #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NebulaModelToHesaiModelNo
was explicitly handling Velodyne models, while it should really just handle everything that isnot Hesai
the same. Because of this, PR #77 and future sensor additions cause warnings in this piece of code (enum value XYZ not handled).PR Type
Description
The function on question now has a generic
default
case for any non-Hesai sensors. Functionally it is exactly the same as before.Review Procedure
Confirm there are no build warnings like "Enum value XYZW not handled in switch statement", confirm in the diff that the code is equivalent.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks