fix(velodyne_msgs): remove local velodyne_msgs package

[drwnz]

PR Type

• Improvement

Related Links

#83

Description

Removes the internal copy of velodyne_msgs and relies on the external dependency.

Review Procedure

• Clean build
• Test operation with Velodyne sensor or ROSbag

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[mojomex]

I think you have to add <depend>velodyne_msgs</depend> to package.xml in nebula_ros, nebula_decoders and nebula_hw_interfaces (otherwise this is just an implicit dependency and will fail on a fresh ROS 2 install).

Also, all occurrences of #include "velodyne_msgs/..." should be changed to #include <velodyne_msgs/...>.

[drwnz]

@mojomex thanks, <depend>velodyne_msgs</depend> was already explicit in all the above except nebula_ros where it was pulled in from the decoders so built fine. But will add it explicitly.
Good catch on the includes. Will modify.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (735138f) 7.91% compared to head (0d8f3e4) 9.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##            main     #93      +/-   ##
========================================
+ Coverage   7.91%   9.20%   +1.28%     
========================================
  Files        108      48      -60     
  Lines       9275    6815    -2460     
  Branches     859     798      -61     
========================================
- Hits         734     627     -107     
+ Misses      7964    5635    -2329     
+ Partials     577     553      -24     

Flag	Coverage Δ
differential	9.20% <ø> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mojomex]

LGTM!