Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logpacker): add rosbag recoding api #114

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ito-san
Copy link
Contributor

@ito-san ito-san commented Mar 18, 2024

Related Links

TIER IV INTERNAL SLACK

Description

The request command should use ROS2 service instead of topic, and the status should be exchanged in numerical format rather than in string.

Changes

  • Request to start/stop rosbag recording
    • /bagpacker/record std_msgs/Bool has been discontinued.
    • Replace this with /api/autoware/set/rosbag_record tier4_external_api_msgs::srv::SetRosbagRecord
  • Status of rosbag recoding
    • /bagpacker/state std_msgs/msg/String has been discontinued.
    • Replace this with /api/autoware/get/rosbag_record_status tier4_external_api_msgs::msg::RosbagRecordStatus
  • Status of whether the ros2 bag record command is currently running or not.
    • /bagpacker/condition std_msgs/Bool has been discontinued since this duplicates the above.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@ito-san ito-san self-assigned this Mar 18, 2024
@ito-san ito-san added the enhancement New feature or request label Mar 18, 2024
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tsugi1203 tsugi1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta self-requested a review March 21, 2024 07:51
@mitsudome-r
Copy link
Collaborator

Memo:

Copy link

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san
Copy link
Contributor Author

ito-san commented Mar 21, 2024

@mitsudome-r

/api/autoware/set/rosbag_record and /api/external/get/rosbag_record_status

The namespace should be shared and it should be /api/autoware. I made changes to the description.

@ito-san
Copy link
Contributor Author

ito-san commented Mar 22, 2024

@mitsudome-r

documentation for TIER IV API page

Filed a new PR, please see tier4/autoware-documentation#44.

@mitsudome-r mitsudome-r merged commit 9aebc8c into tier4:tier4/universe Mar 25, 2024
13 checks passed
TomohitoAndo pushed a commit that referenced this pull request Mar 29, 2024
h-ohta pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants