-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_simulation_msgs): add traffic light v1 messages #120
feat(tier4_simulation_msgs): add traffic light v1 messages #120
Conversation
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto [email protected]
…1.msg Signed-off-by: Kotaro Yoshimoto [email protected]
…in TrafficLightBulbV1.msg Signed-off-by: Kotaro Yoshimoto [email protected]
Which specific types of autoware_auto_msgs are you referring to? |
@yukkysaito
The correspondence with
I don't intend to do a migration. |
I think what @HansRobo is trying to represent with this new message is individual traffic light instead of TrafficLightGroup (which is a group of traffic lights with same behavior). |
Could you also explain if this message will be used to communicate between Autoware and a simulator (e.g., scenario_simulator) or is this just for internal communication within simulator modules? |
This message is used for output from ScenarioSimulator to external. |
exactly. |
@HansRobo Thanks for your reply |
The information is sufficient in the existing TrafficLight.
|
How should we proceed with this PR? |
Note: The visualization of traffic lights on Autoware Evaluator was implemented and released based on these messages. |
The messages are moved into scenario_simulator_v2 |
Signed-off-by: Kotaro Yoshimoto [email protected]
Related Links
Description
The messages for traffic light was changed not to represent physical traffic lights, in autoware_perception_msgs.
This change made difficult to visualize or do something about physical traffic lights based on Autoware's traffic light topic.
These messages are for treating physical traffic light instead of old
autoware_auto_perception_msgs
.Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks