-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_localization_msgs): add reliability for localization pose #143
feat(tier4_localization_msgs): add reliability for localization pose #143
Conversation
Signed-off-by: RyuYamamoto <[email protected]>
Could you please confirm the clear distinction between "success" and "reliable"? Does the "success" field become false when the initial pose estimation wasn't performed in the first place? When the initial pose estimation is clearly incorrect, does "success" become false and "reliable" also become false? |
If failure to run initial pose estimation with some reason and could not get result, set
In that case, without checking reliable, transition UNINTIALIZED Status.
|
Thank you for your explanation. I understand that there are reasonable grounds. 👍 |
Signed-off-by: RyuYamamoto <[email protected]>
I will also include a comment in srv files. |
Signed-off-by: RyuYamamoto <[email protected]>
@yukkysaito @mitsudome-r Could you please check the PR? |
Thank you. The changes themselves seem good. Due to various circumstances, we need to carefully consider the impact of this PR within the company. Please wait a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Links
autowarefoundation/autoware.universe#8275
Description
Added
reliability
variable to PoseWithCovarianceStamped.csv.For the following PR, I would like to add
reliability
variable to check the reliability of the initial pose estimation result with localization score.autowarefoundation/autoware.universe#8275
As a reason for that I want to separate bool variable for whether initial pose estimation has completed successfully and whether initial pose estimation results is reliable.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks