pd http: support api to get store min resolved ts #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuSharp
force-pushed
the
add_store_min_resolved_ts
branch
from
88d7fa8
to
acb6745
Compare
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
add_store_min_resolved_ts
branch
from
acb6745
to
1648fc9
Compare
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
JmPotato
reviewed
May 10, 2023
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
add_store_min_resolved_ts
branch
from
036d5b5
to
b2d9fe6
Compare
JmPotato
reviewed
May 11, 2023
integration_tests/raw/api_test.go
Outdated
| return c.Client.CloseAddr(addr) | ||
| } | ||
|
|
||
| func (s *apiTestSuite) TestGetStoreMinResolvedTS() { |
There was a problem hiding this comment.
I don't think it's proper to put resolved_ts test inside integration_tests/raw/api_test.go since it's for the RawKV API testing.
There was a problem hiding this comment.
move to pd_api_test file
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
|
@Defined2014 PTAL, thx! |
JmPotato
reviewed
May 11, 2023
Signed-off-by: husharp <[email protected]>
JmPotato
reviewed
May 11, 2023
| return | ||
| // Try to get the minimum resolved timestamp of the store from PD. | ||
| if s.pdHttpClient != nil { | ||
| safeTS, err = s.pdHttpClient.GetStoreMinResolvedTS(ctx, storeID) |
There was a problem hiding this comment.
We could add a debug log to output safeTS and err when it's not nil.
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
add_store_min_resolved_ts
branch
from
e708d8a
to
6e4bfa5
Compare
JmPotato
approved these changes
May 11, 2023
disksing
pushed a commit
that referenced
this pull request
May 16, 2023
Signed-off-by: husharp <[email protected]>
iosmanthus
added a commit
that referenced
this pull request
May 22, 2023
Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: Violin <[email protected]> Co-authored-by: Smilencer <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Connor <[email protected]> Co-authored-by: zyguan <[email protected]> fix case typo in comment. (#778) fix goroutine leak (#784) fix TestRURuntimeStatsCleanUp (#787) Fix wrong resource group name for some requests (#788) resolver: support verifying primary for check_txn_status (#777) resolver: handle pessimistic locks in BatchResolveLocks (#794) resolved ts (#793) ResolveLocks for unistore (#807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #795
after tikv/pd#6413 merged, We can replace resolved-ts's current implementation in client-go