Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the TSO server metrics #7011

Closed
3 tasks done
JmPotato opened this issue Aug 30, 2023 · 1 comment
Closed
3 tasks done

Enhance the TSO server metrics #7011

JmPotato opened this issue Aug 30, 2023 · 1 comment
Assignees
@JmPotato
Labels
component/keyspace Key space. component/metrics Metrics. component/tso Timestamp Oracle. type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

JmPotato commented Aug 30, 2023 •
edited
Loading

Part of #5895

Enhancement Task

Currently, we have basically finished the development of the multi-tenant TSO service. Now is an excellent time to improve the observability of it. We may still need to introduce a lot of metrics to help us monitor the keyspace group and TSO-related indicators.
@JmPotato JmPotato added type/enhancement The issue or PR belongs to an enhancement. component/metrics Metrics. component/tso Timestamp Oracle. component/keyspace Key space. labels Aug 30, 2023
@JmPotato JmPotato self-assigned this Aug 30, 2023
@JmPotato JmPotato mentioned this issue Aug 30, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Aug 31, 2023
@JmPotato @ti-chi-bot
tso: pre-initialize the TSO metrics with the group label (#7012)
a7353bb 
ref #7011

Pre-initialize the TSO metrics with the group label.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato JmPotato mentioned this issue Aug 31, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Sep 1, 2023
@JmPotato @ti-chi-bot
tso: add some metrics for Keyspace Group operations (#7022)
87f2da8 
ref #7011

Add some metrics for Keyspace Group operations.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato JmPotato mentioned this issue Sep 4, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 5, 2023
@JmPotato
mcs, tso: add more metrics on the TSO critical path (#7040)
7d50755 
ref #7011

Add more metrics on the TSO critical path to monitor some key duration costs.

Signed-off-by: JmPotato <[email protected]>
@rleungx
Copy link
Member

rleungx commented Sep 12, 2023

Is it finished now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
component/keyspace Key space. component/metrics Metrics. component/tso Timestamp Oracle. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JmPotato @rleungx