Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: pre-initialize the TSO metrics with the group label #7012

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 30, 2023

What problem does this PR solve?

Issue Number: ref #7011.

What is changed and how does it work?

Pre-initialize the TSO metrics with the group label.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image image

Release note

None.

@JmPotato JmPotato added component/metrics Metrics. component/tso Timestamp Oracle. labels Aug 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #7012 (b256008) into master (7a4e1e2) will decrease coverage by 0.03%.
The diff coverage is 85.84%.

@@            Coverage Diff             @@
##           master    #7012      +/-   ##
==========================================
- Coverage   74.20%   74.17%   -0.03%     
==========================================
  Files         433      433              
  Lines       46101    46139      +38     
==========================================
+ Hits        34209    34225      +16     
- Misses       8872     8892      +20     
- Partials     3020     3022       +2     
Flag Coverage Δ
unittests 74.17% <85.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2023
@JmPotato JmPotato mentioned this pull request Aug 30, 2023
3 tasks
pkg/tso/tso.go Outdated Show resolved Hide resolved
pkg/tso/tso.go Outdated Show resolved Hide resolved
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1d46992

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit a7353bb into tikv:master Aug 31, 2023
23 checks passed
@JmPotato JmPotato deleted the keyspace_group_tso_metrics branch August 31, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. component/tso Timestamp Oracle. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants