Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: supports to add gRPC dial options (#2035) (#2043) #2046

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 23, 2019

cherry-pick #2043 to release-3.1


Signed-off-by: nolouch [email protected]

What problem does this PR solve?

cherry-pick #2035

What is changed and how it works?

add an option.

Check List

Tests

  • Unit test

@sre-bot sre-bot added status/can-merge Indicates a PR has been approved by a committer. cherry-pick labels Dec 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #2046 into release-3.1 will decrease coverage by 0.18%.
The diff coverage is 92.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.1    #2046      +/-   ##
===============================================
- Coverage        69.66%   69.47%   -0.19%     
===============================================
  Files              171      171              
  Lines            16837    16846       +9     
===============================================
- Hits             11729    11704      -25     
- Misses            4136     4159      +23     
- Partials           972      983      +11
Impacted Files Coverage Δ
client/client.go 74.53% <92.85%> (+0.48%) ⬆️
pkg/tempurl/tempurl.go 57.14% <0%> (-14.29%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/util.go 68.15% <0%> (-7.01%) ⬇️
server/schedulers/shuffle_hot_region.go 58.97% <0%> (-6.42%) ⬇️
server/namespace_cluster.go 81.81% <0%> (-3.9%) ⬇️
server/leader.go 79.59% <0%> (-2.45%) ⬇️
server/tso.go 74.35% <0%> (-1.71%) ⬇️
server/grpc_service.go 59.91% <0%> (-0.64%) ⬇️
server/cluster.go 81.31% <0%> (-0.51%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce91ee9...6ac15df. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 23, 2019

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented Dec 24, 2019

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit 529de48 into tikv:release-3.1 Dec 24, 2019
@AndreMouche AndreMouche added this to the v3.1.0-beta.1 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants