scheduler: refactor hotspot scheduler #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luffbee
added
component/schedule
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
==========================================
- Coverage 76.66% 76.51% -0.15%
==========================================
Files 194 194
Lines 19756 19756
==========================================
- Hits 15146 15117 -29
- Misses 3478 3507 +29
Partials 1132 1132
Continue to review full report at Codecov.
|
nolouch
reviewed
Jan 19, 2020
| } | ||
| } | ||
| if id != 0 && bs.cluster.GetStore(id) == nil { |
There was a problem hiding this comment.
need a metrics when cannot select src store.
There was a problem hiding this comment.
The original code do not have such metric, so I don't think this should be added in this PR.
nolouch
reviewed
Jan 19, 2020
disksing
reviewed
Jan 20, 2020
| pendingOpInfos: pendingOpInfos, | ||
| } | ||
| ret := newHotScheduler(opController) | ||
| ret.name = "" |
There was a problem hiding this comment.
The original code didn't set name, so it should be empty string.
rleungx
reviewed
Jan 20, 2020
server/schedulers/hot_region.go
Outdated
| if len(candidateStoreIDs) == 0 { | ||
| continue | ||
| if pendings[movePeer] != nil || | ||
| (pendings[transferLeader] != nil && !pendings[transferLeader].isDone()) { |
There was a problem hiding this comment.
Maybe add it in another PR.
disksing
approved these changes
Jan 20, 2020
nolouch
approved these changes
Jan 20, 2020
nolouch
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The hotspot scheduler has duplicate code and its logic is not very clear.
What is changed and how it works?
Refactored the
hotScheduler. Mainly three part:pendingOpInfosrelated code (introduced by PR client: supports to add gRPC dial options (#2035) (#2043) #2046 and rename it toregionPendings. (the 1st commit)balanceHot{Read, Write}Regions()intobalanceBy{Peer, Leader}(). (the 2ed commit)balanceSolverto replacebalanceBy{Peer, Leader}(). (the 4th & 5th commit).The reason for introducing
balanceSolveris that the logic ofbalanceBy{Peer, Leader}()are similar, which can be described generally asbalanceSolver.solve().Check List
Tests