member: refactor election #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JmPotato
added
do-not-merge/work-in-progress
JmPotato
changed the title
|
/run-all-tests |
|
/rebuild |
JmPotato
force-pushed
the
refactor_election
branch
from
e4fe72a
to
63511dd
Compare
JmPotato
removed
the
do-not-merge/work-in-progress
|
/run-all-tests |
disksing
reviewed
Aug 14, 2020
disksing
reviewed
Aug 14, 2020
Yisaer
reviewed
Aug 17, 2020
JmPotato
force-pushed
the
refactor_election
branch
3 times, most recently
from
17aedaf
to
9842a0c
Compare
JmPotato
added
status/DNM
do-not-merge/work-in-progress
JmPotato
removed
the
do-not-merge/work-in-progress
JmPotato
force-pushed
the
refactor_election
branch
2 times, most recently
from
e81abf1
to
41a99ec
Compare
Signed-off-by: 混沌DM <[email protected]> Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
refactor_election
branch
from
3853900
to
5b47a8f
Compare
Signed-off-by: JmPotato <[email protected]>
|
/run-all-tests |
|
@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
LGTM |
|
@ZenoTan,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
This was referenced Aug 20, 2020
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]> Signed-off-by: ZenoTan <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Part of #2759. Refactor election logic.
What is changed and how it works?
Pull away some common methods of election from
memberand prepare for incoming TSO refactoring next.Check List
Tests
Code changes
Release note
Refactor election logic.