tso: refactor the tso service #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
reviewed
Aug 20, 2020
nolouch
reviewed
Aug 20, 2020
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Yisaer
reviewed
Aug 21, 2020
Signed-off-by: JmPotato <[email protected]>
|
@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-build-image |
16 tasks
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]> Signed-off-by: ZenoTan <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
This was referenced May 5, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Part of #2759. Refactor the tso service to use
LeadershipandTSOAllocator. After adding the new feature of local TSO allocator in the future, there will be two kinds of member roles need to be elected, one is PD leader, another is Local TSO Allocator. For more details, you can check this document.What is changed and how it works?
Modify the tso package to be more extendable as a
TSOAllocatorin order to introduce the Local TSO Allocator and new Global TSO Allocator later.Check List
Tests
Code changes
Related changes
Release note