server: partially fix grpc status

[rleungx]

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #4797.

What is changed and how it works?

This PR removes unnecessary withStack and partially fix the above issue.

Check List

Tests

• Unit test

Release note

Fix the issue that the status code of `not leader` is sometimes wrong 

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JmPotato
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4798 (6ef6169) into master (bd1a18b) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #4798      +/-   ##
==========================================
- Coverage   75.24%   75.22%   -0.02%     
==========================================
  Files         294      294              
  Lines       28509    28509              
==========================================
- Hits        21452    21447       -5     
- Misses       5151     5156       +5     
  Partials     1906     1906              

Flag	Coverage Δ
unittests	75.22% <25.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/grpc_service.go	54.61% <25.00%> (+0.45%)	⬆️
pkg/metricutil/metricutil.go	82.75% <0.00%> (-10.35%)	⬇️
server/schedulers/shuffle_hot_region.go	55.55% <0.00%> (-10.11%)	⬇️
server/schedule/region_scatterer.go	78.99% <0.00%> (-4.21%)	⬇️
server/election/leadership.go	73.19% <0.00%> (-2.07%)	⬇️
server/statistics/store_collection.go	93.66% <0.00%> (-1.41%)	⬇️
pkg/btree/btree.go	87.37% <0.00%> (-0.76%)	⬇️
server/cluster/coordinator.go	75.11% <0.00%> (-0.24%)	⬇️
client/client.go	70.10% <0.00%> (-0.11%)	⬇️
server/member/member.go	63.68% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1a18b...6ef6169. Read the comment docs.

[AndreMouche]

LGTM

[ti-chi-bot]

@AndreMouche: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[JmPotato]

/merge

[ti-chi-bot]

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 258b74b

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5214.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5215.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5216.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5217.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5218.