-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: partially fix grpc status (#4798) #5218
server: partially fix grpc status (#4798) #5218
Conversation
ref tikv#4797 Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Ryan Leung <[email protected]>
c975c11
to
c60d162
Compare
Codecov Report
@@ Coverage Diff @@
## release-5.4 #5218 +/- ##
===============================================
- Coverage 74.72% 74.66% -0.07%
===============================================
Files 265 265
Lines 27989 27989
===============================================
- Hits 20916 20897 -19
- Misses 5203 5220 +17
- Partials 1870 1872 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c60d162
|
This is an automated cherry-pick of #4798
Signed-off-by: Ryan Leung [email protected]
What problem does this PR solve?
Issue Number: Ref #4797.
What is changed and how it works?
This PR removes unnecessary
withStack
and partially fix the above issue.Check List
Tests
Release note