Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: partially fix grpc status (#4798) #5218

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4798

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #4797.

What is changed and how it works?

This PR removes unnecessary withStack and partially fix the above issue.

Check List

Tests

  • Unit test (TODO)

Release note

Fix the issue that the status code of `not leader` is sometimes wrong 

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jun 22, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 22, 2022
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-4798-to-release-5.4 branch from c975c11 to c60d162 Compare June 22, 2022 11:40
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #5218 (c60d162) into release-5.4 (0204bfa) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@               Coverage Diff               @@
##           release-5.4    #5218      +/-   ##
===============================================
- Coverage        74.72%   74.66%   -0.07%     
===============================================
  Files              265      265              
  Lines            27989    27989              
===============================================
- Hits             20916    20897      -19     
- Misses            5203     5220      +17     
- Partials          1870     1872       +2     
Flag Coverage Δ
unittests 74.66% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 51.20% <33.33%> (-0.78%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/region_syncer/server.go 82.69% <0.00%> (-5.13%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
server/schedule/operator_controller.go 83.02% <0.00%> (-1.23%) ⬇️
server/tso/global_allocator.go 60.84% <0.00%> (-1.06%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0204bfa...c60d162. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022
@nolouch
Copy link
Contributor

nolouch commented Jun 23, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c60d162

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@ti-chi-bot ti-chi-bot merged commit 7646455 into tikv:release-5.4 Jun 23, 2022
@purelind purelind added this to the v5.4.2 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants