storage: add TSO storage #5874

rleungx · 2023-01-19T08:08:03Z

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #5849.

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None

ti-chi-bot · 2023-01-19T08:08:05Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

rleungx · 2023-01-19T08:08:44Z

@binshi-bing PTAL

codecov · 2023-01-19T08:21:34Z

Codecov Report

Base: 75.76% // Head: 75.68% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (a2ca8f2) compared to base (248b3f0).
Patch coverage: 74.35% of modified lines in pull request are covered.

❗ Current head a2ca8f2 differs from pull request most recent head 40afd2b. Consider uploading reports for the commit 40afd2b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5874      +/-   ##
==========================================
- Coverage   75.76%   75.68%   -0.08%     
==========================================
  Files         343      344       +1     
  Lines       35022    35059      +37     
==========================================
+ Hits        26533    26535       +2     
- Misses       6223     6251      +28     
- Partials     2266     2273       +7

Flag	Coverage Δ
unittests	`75.68% <74.35%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/storage/endpoint/resource_group.go	`100.00% <ø> (ø)`
pkg/tso/allocator_manager.go	`64.19% <0.00%> (-1.30%)`	⬇️
server/storage/storage.go	`71.15% <ø> (ø)`
pkg/storage/endpoint/tso.go	`64.00% <64.00%> (ø)`
pkg/mock/mockcluster/mockcluster.go	`94.25% <100.00%> (ø)`
pkg/storage/endpoint/key_path.go	`94.64% <100.00%> (+1.46%)`	⬆️
pkg/dashboard/keyvisual/input/core.go	`0.00% <0.00%> (-33.34%)`	⬇️
pkg/errs/errs.go	`75.00% <0.00%> (-25.00%)`	⬇️
pkg/id/id.go	`86.44% <0.00%> (-3.39%)`	⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

binshi-bing

left some comments

pkg/storage/endpoint/key_path.go

pkg/storage/endpoint/tso.go

binshi-bing · 2023-01-26T19:42:30Z

pkg/storage/endpoint/tso.go

+	}
+
+	maxTSWindow := typeutil.ZeroTime
+	for i, key := range keys {


When will it return multiple keys?

versioning?

I think local TSO might use it.

pkg/storage/endpoint/tso.go

binshi-bing

LGTM, though my vote won't be counted

ti-chi-bot · 2023-02-02T17:48:38Z

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

server/storage/storage_tso_test.go

pkg/storage/endpoint/tso.go

Signed-off-by: Ryan Leung <[email protected]>

rleungx · 2023-02-06T05:20:50Z

/run-all-tests

rleungx · 2023-02-06T05:32:30Z

/merge

ti-chi-bot · 2023-02-06T05:32:31Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-02-06T05:32:33Z

This pull request has been accepted and is ready to merge.

Commit hash: bff0ced

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 19, 2023

rleungx requested review from nolouch and JmPotato and removed request for nolouch January 19, 2023 08:08

ti-chi-bot requested a review from nolouch January 19, 2023 08:08

rleungx force-pushed the tso-storage branch from 999e783 to 3bfae24 Compare January 19, 2023 08:12

rleungx mentioned this pull request Jan 19, 2023

Provide API service interfaces #5849

Closed

3 tasks

binshi-bing reviewed Jan 26, 2023

View reviewed changes

binshi-bing mentioned this pull request Feb 2, 2023

Separate TSO into an independent service #5836

Closed

rleungx force-pushed the tso-storage branch 3 times, most recently from 78bf86f to fd56a3d Compare February 2, 2023 04:35

binshi-bing approved these changes Feb 2, 2023

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023

JmPotato reviewed Feb 3, 2023

View reviewed changes

server/storage/storage_tso_test.go Outdated Show resolved Hide resolved

pkg/storage/endpoint/tso.go Outdated Show resolved Hide resolved

rleungx added 2 commits February 3, 2023 10:55

add tso storage

75236a1

Signed-off-by: Ryan Leung <[email protected]>

address the comment

6519168

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the tso-storage branch from fd56a3d to a2ca8f2 Compare February 3, 2023 05:13

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023

address comments

bff0ced

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the tso-storage branch from a2ca8f2 to bff0ced Compare February 3, 2023 05:20

rleungx requested a review from JmPotato February 3, 2023 05:20

JmPotato approved these changes Feb 3, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2023

rleungx requested a review from lhy1024 February 3, 2023 06:44

lhy1024 approved these changes Feb 6, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 6, 2023

Merge branch 'master' into tso-storage

40afd2b

ti-chi-bot merged commit 5202abe into tikv:master Feb 6, 2023

rleungx deleted the tso-storage branch February 6, 2023 05:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: add TSO storage #5874

storage: add TSO storage #5874

rleungx commented Jan 19, 2023

ti-chi-bot commented Jan 19, 2023 •

edited

Loading

rleungx commented Jan 19, 2023

codecov bot commented Jan 19, 2023 •

edited

Loading

binshi-bing left a comment

binshi-bing Jan 26, 2023

binshi-bing Jan 27, 2023

rleungx Feb 2, 2023

binshi-bing left a comment •

edited

Loading

ti-chi-bot commented Feb 2, 2023

rleungx commented Feb 6, 2023

rleungx commented Feb 6, 2023

ti-chi-bot commented Feb 6, 2023

ti-chi-bot commented Feb 6, 2023

storage: add TSO storage #5874

storage: add TSO storage #5874

Conversation

rleungx commented Jan 19, 2023

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Jan 19, 2023 • edited Loading

rleungx commented Jan 19, 2023

codecov bot commented Jan 19, 2023 • edited Loading

Codecov Report

binshi-bing left a comment

Choose a reason for hiding this comment

binshi-bing Jan 26, 2023

Choose a reason for hiding this comment

binshi-bing Jan 27, 2023

Choose a reason for hiding this comment

rleungx Feb 2, 2023

Choose a reason for hiding this comment

binshi-bing left a comment • edited Loading

Choose a reason for hiding this comment

ti-chi-bot commented Feb 2, 2023

rleungx commented Feb 6, 2023

rleungx commented Feb 6, 2023

ti-chi-bot commented Feb 6, 2023

ti-chi-bot commented Feb 6, 2023

ti-chi-bot commented Jan 19, 2023 •

edited

Loading

codecov bot commented Jan 19, 2023 •

edited

Loading

binshi-bing left a comment •

edited

Loading