Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix unexpected log #6286

Merged
merged 1 commit into from
Apr 7, 2023
Merged

*: fix unexpected log #6286

merged 1 commit into from
Apr 7, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 7, 2023

What problem does this PR solve?

Issue Number: Close #6285.

What is changed and how does it work?

Fix the issue mentioned above.

Check List

Tests

  • Unit test

Release note

None.

@rleungx
fix unexpected log
1d09296 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 7, 2023
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (976be4b) 75.18% compared to head (1d09296) 75.13%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6286      +/-   ##
==========================================
- Coverage   75.18%   75.13%   -0.06%     
==========================================
  Files         404      404              
  Lines       39350    39350              
==========================================
- Hits        29587    29564      -23     
- Misses       7196     7216      +20     
- Partials     2567     2570       +3
Flag Coverage Δ
unittests 75.13% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pd_service_discovery.go 87.20% <100.00%> (ø)

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2023
@rleungx
Copy link
Member Author

rleungx commented Apr 7, 2023

/run-check-issue-triage-complete

@rleungx
Copy link
Member Author

rleungx commented Apr 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1d09296

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2023
@ti-chi-bot ti-chi-bot merged commit 2f0229f into tikv:master Apr 7, 2023
@rleungx rleungx deleted the fix-log branch April 7, 2023 11:13
rleungx added a commit to rleungx/pd that referenced this pull request Jun 5, 2023
@binshi-bing @rleungx @ti-chi-bot
fixes for bugs and flaky tests (tikv#71)
df2e3bf 
* *: fix `TestConcurrentlyReset` (tikv#6318)

close tikv#6275

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>

* *: fix unexpected log (tikv#6286)

close tikv#6285

Signed-off-by: Ryan Leung <[email protected]>

* *: make TestGlobalAndLocalTSO stable (tikv#6292)

close tikv#6250

Signed-off-by: Ryan Leung <[email protected]>

* *: fix `TestLogicalOverflow` (tikv#6320)

close tikv#6277

Signed-off-by: Ryan Leung <[email protected]>

---------

Signed-off-by: Ryan Leung <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected log field
3 participants
@rleungx @ti-chi-bot @JmPotato