Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make TestGlobalAndLocalTSO stable #6292

Merged
merged 2 commits into from
Apr 10, 2023
Merged

*: make TestGlobalAndLocalTSO stable #6292

merged 2 commits into from
Apr 10, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 10, 2023

What problem does this PR solve?

Issue Number: Close #6250.

What is changed and how does it work?

Ignore the leader change error to make test more stable.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • binshi-bing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 10, 2023
@rleungx rleungx requested review from JmPotato and binshi-bing and removed request for nolouch and disksing April 10, 2023 04:05
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (bfdc7ec) 75.09% compared to head (dc181b2) 75.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6292      +/-   ##
==========================================
+ Coverage   75.09%   75.30%   +0.20%     
==========================================
  Files         404      404              
  Lines       39350    39350              
==========================================
+ Hits        29549    29631      +82     
+ Misses       7228     7173      -55     
+ Partials     2573     2546      -27
Flag Coverage Δ
unittests 75.30% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2023
JmPotato
JmPotato reviewed Apr 10, 2023
View reviewed changes
tests/integrations/client/client_test.go Outdated
Comment on lines 460 to 462
} else {
re.NoError(err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary since err will always be nil in this branch.

@rleungx
address the comment
dc181b2 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested a review from JmPotato April 10, 2023 08:20
nolouch
nolouch approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc181b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2023
@ti-chi-bot ti-chi-bot merged commit 7fe8d17 into tikv:master Apr 10, 2023
@rleungx rleungx deleted the stable-test7 branch April 10, 2023 08:46
rleungx added a commit to rleungx/pd that referenced this pull request Jun 5, 2023
@binshi-bing @rleungx @ti-chi-bot
fixes for bugs and flaky tests (tikv#71)
df2e3bf 
* *: fix `TestConcurrentlyReset` (tikv#6318)

close tikv#6275

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>

* *: fix unexpected log (tikv#6286)

close tikv#6285

Signed-off-by: Ryan Leung <[email protected]>

* *: make TestGlobalAndLocalTSO stable (tikv#6292)

close tikv#6250

Signed-off-by: Ryan Leung <[email protected]>

* *: fix `TestLogicalOverflow` (tikv#6320)

close tikv#6277

Signed-off-by: Ryan Leung <[email protected]>

---------

Signed-off-by: Ryan Leung <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binshi-bing binshi-bing binshi-bing approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestGlobalAndLocalTSO failed
5 participants
@rleungx @ti-chi-bot @JmPotato @nolouch @binshi-bing