-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsafe recovery: Fix learner nodes got ignored in auto detect mode error #6691
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @Connor1996 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6691 +/- ##
==========================================
- Coverage 74.59% 74.54% -0.06%
==========================================
Files 416 416
Lines 43543 43541 -2
==========================================
- Hits 32482 32458 -24
- Misses 8180 8195 +15
- Partials 2881 2888 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8dcab64
|
Signed-off-by: Yang Zhang <[email protected]>
440c062
to
1414baf
Compare
/merge |
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1414baf
|
@v01dstar: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
ref tikv#6683, close tikv#6690 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…ror (tikv#6691) ref tikv#6683, close tikv#6690 Fix learner nodes got ignored in auto detect mode error Signed-off-by: Yang Zhang <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
In response to a cherrypick label: new pull request created to branch |
…ror (tikv#6691) ref tikv#6683, close tikv#6690 Fix learner nodes got ignored in auto detect mode error Signed-off-by: Yang Zhang <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #6690
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
This PR does not need to be cherry-picked into release 6.5, since the customized PR #6683 will be.
Release note