Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6709

Closed
wants to merge 1 commit into from
Closed

unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6709

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6691

What problem does this PR solve?

Issue Number: Close #6690

What is changed and how does it work?

Fix learner nodes got ignored in auto detect mode error

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

This PR does not need to be cherry-picked into release 6.5, since the customized PR #6683 will be.

Release note

None.

@v01dstar @ti-chi-bot @ti-chi-bot
unsafe recovery: Fix learner nodes got ignored in auto detect mode er…
6fb1419 
…ror (tikv#6691)

ref tikv#6683, close tikv#6690

Fix learner nodes got ignored in auto detect mode error

Signed-off-by: Yang Zhang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx June 29, 2023 01:16
@v01dstar v01dstar mentioned this pull request Jul 3, 2023
Merged
@v01dstar
Copy link
Contributor

v01dstar commented Jul 3, 2023

A manual cherry-pick has been proposed in #6683, This PR should be closed once #6683 is merged

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 4, 2023

@v01dstar ci failed.

ti-chi-bot bot added a commit that referenced this pull request Jul 4, 2023
@v01dstar @ti-chi-bot
unsafe recovery: Fixing learner store being ignored error (#6683)
15324c5 
ref #6690, ref #6709

Fix learner store/ replica being ignored error in auto detect mode.

Signed-off-by: Yang Zhang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Contributor

nolouch commented Jul 11, 2023

duplicated https://github.com/tikv/pd/pull/6683/files

@nolouch nolouch closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @v01dstar @nolouch