-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix scheduler save config #7108
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
143025b
to
2a43640
Compare
2a43640
to
27dc121
Compare
27dc121
to
826304c
Compare
Signed-off-by: husharp <[email protected]>
5d021bd
to
a5cdd29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #7108 +/- ##
==========================================
+ Coverage 74.26% 74.28% +0.01%
==========================================
Files 441 441
Lines 47216 47220 +4
==========================================
+ Hits 35064 35076 +12
+ Misses 9063 9044 -19
- Partials 3089 3100 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request has been accepted and is ready to merge. Commit hash: 122f9f3
|
In response to a cherrypick label: new pull request created to branch |
close tikv#6897 Signed-off-by: ti-chi-bot <[email protected]>
close tikv#6897 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
close tikv#6897 Signed-off-by: ti-chi-bot <[email protected]>
close tikv#6897 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#6897 Signed-off-by: ti-chi-bot <[email protected]>
close #6897 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: Hu# <[email protected]>
close #6897 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close #6897 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close tikv#6897 Signed-off-by: husharp <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close #6897 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: Hu# <[email protected]>
What problem does this PR solve?
Issue Number: Close #6897
What is changed and how does it work?
Nowadays we have 2 configs setting way
We need to make sure that create just means create and not further save the configuration
Check List
Tests
Release note