-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix scheduler save config (#7108) #7162
scheduler: fix scheduler save config (#7108) #7162
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: husharp <[email protected]>
d7f9ded
to
bdd0bbe
Compare
Signed-off-by: husharp <[email protected]>
CI failed |
Signed-off-by: husharp <[email protected]>
Codecov ReportAttention:
... and 26 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 602e806
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #7108
What problem does this PR solve?
Issue Number: Close #6897
What is changed and how does it work?
Nowadays we have 2 configs setting way
We need to make sure that create just means create and not further save the configuration
Check List
Tests
Release note