-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region: check if the query startkey and endkey specify an uncovered region #8743
Conversation
Signed-off-by: Boyang Lyu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JackL9u. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
The tests failed. |
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8743 +/- ##
==========================================
- Coverage 70.10% 70.02% -0.09%
==========================================
Files 517 517
Lines 79983 80029 +46
==========================================
- Hits 56076 56038 -38
- Misses 20339 20425 +86
+ Partials 3568 3566 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Is this pr ready to review? |
What problem does this PR solve?
when the query region [startKey, endKey] is an uncovered region, the function GetRegionCount now returns 0.
Issue Number: ref #6711
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note