Add option to specify threads and tasks on 1.8 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/handle_meta
branch
from
859b6ba
to
a7ceeae
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 92.79% 92.87% +0.08%
==========================================
Files 5 5
Lines 347 351 +4
==========================================
+ Hits 322 326 +4
Misses 25 25
Continue to review full report at Codecov.
|
IanButterworth
force-pushed
the
ib/handle_meta
branch
from
a7ceeae
to
9de1223
Compare
IanButterworth
force-pushed
the
ib/handle_meta
branch
from
9565c06
to
dd3ae3b
Compare
|
@timholy this should be ready for review now It works with timholy/ProfileView.jl#176 |
|
I'd be happy to merge this, do a patch release, and finish up timholy/ProfileView.jl#176 if you don't have time to review, and are ok with that, @timholy ? |
|
I have a ton of faith in your work, so in the absence of feedback from me, go for it! I haven't yet poked at this, but the plan sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to get ProfileView setup to handle this before claiming victory, but here's WIP over here.
My general strategy is to generate one flamegraph per threadid or all_threads, and stack them in the ProfileView window with some form of combobox selector for
[all, 1, 2, 3, 4 ...].As opposed to somehow embedding the thread info into the flamegraph itself and selectively pruning it in the GUI.