Skip to content

Inherit all PerSegment models from PerSegmentModel #543

Merged
merged 7 commits into from
Feb 18, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Feb 18, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #508

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Feb 18, 2022
@alex-hse-repository alex-hse-repository self-assigned this Feb 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #543 (1f49044) into master (ab902ba) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.02%     
==========================================
  Files         118      118              
  Lines        5797     5788       -9     
==========================================
- Hits         5060     5051       -9     
  Misses        737      737              
Impacted Files Coverage Δ
etna/models/base.py 77.44% <100.00%> (ø)
etna/models/catboost.py 100.00% <100.00%> (ø)
etna/models/holt_winters.py 98.76% <100.00%> (+0.01%) ⬆️
etna/models/seasonal_ma.py 97.05% <100.00%> (+0.08%) ⬆️
etna/models/sklearn.py 96.07% <100.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab902ba...1f49044. Read the comment docs.

@alex-hse-repository alex-hse-repository merged commit 2242d40 into master Feb 18, 2022
@iKintosh iKintosh deleted the issue-508 branch March 22, 2022 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherit all PerSegment models from PerSegmentModel
3 participants