Skip to content

Add regressors updating in transform loops #374

Merged
merged 11 commits into from
Dec 29, 2021

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Dec 13, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #328

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Dec 13, 2021
@alex-hse-repository alex-hse-repository added this to the Regressors 2.0 milestone Dec 13, 2021
@alex-hse-repository alex-hse-repository self-assigned this Dec 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (breaking_change/regressors@40fe88c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             breaking_change/regressors     #374   +/-   ##
=============================================================
  Coverage                              ?   87.57%           
=============================================================
  Files                                 ?       96           
  Lines                                 ?     4741           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     4152           
  Misses                                ?      589           
  Partials                              ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fe88c...17d737a. Read the comment docs.

@alex-hse-repository alex-hse-repository linked an issue Dec 13, 2021 that may be closed by this pull request
1 task
@martins0n martins0n self-requested a review December 14, 2021 07:56
etna/datasets/tsdataset.py Show resolved Hide resolved
etna/datasets/tsdataset.py Outdated Show resolved Hide resolved
tests/test_datasets/test_dataset.py Outdated Show resolved Hide resolved
etna/datasets/tsdataset.py Outdated Show resolved Hide resolved
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to update breaking_change/regressors.
Current diff has redundant code.

etna/datasets/tsdataset.py Show resolved Hide resolved
etna/datasets/tsdataset.py Outdated Show resolved Hide resolved
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update _update_regressors logic with new transforms behavior
3 participants