-
Notifications
You must be signed in to change notification settings - Fork 80
Add regressors updating in transform loops #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## breaking_change/regressors #374 +/- ##
=============================================================
Coverage ? 87.57%
=============================================================
Files ? 96
Lines ? 4741
Branches ? 0
=============================================================
Hits ? 4152
Misses ? 589
Partials ? 0 Continue to review full report at Codecov.
|
1 task
martins0n
suggested changes
Dec 14, 2021
Fix bug with column names in `SklearnTransform`
martins0n
suggested changes
Dec 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to update breaking_change/regressors
.
Current diff has redundant code.
martins0n
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
alex-hse-repository
added a commit
that referenced
this pull request
Jan 31, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 1, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 8, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 14, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #328