-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Proton versions detection #101
Comments
Did they actually changed appid? It will work if not. Also there probably should be some file in Steam client with available versions list. |
Uhm. I think we are using the latest version, but for some reason, Proton always reports 2.7-2 in the logs: |
There's now Proton 3.16 with appid 961940:
Do you have any better ideas than iterating I've looked in Steam configs and haven't found anything useful. It's possible to add an entry in settings, but that does not seem to be very user-friendly. |
If we are monitoring the Proton progress, I think it is reasonable to hard-code the appids and ask the users to upgrade GameHub when there is a new version of Proton. |
Fix Proton prefix init Add simple download speed counter
Anyway I can update the proton version used in GameHub? Right now im at 3.16, and on my steam client it says 3.16-8 beta |
Isn't Proton 3.16 beta the last one? |
@Hedronmx minor Proton updates are not separate Steam apps. GameHub will use latest Proton version as long as app ids are same. When new major Proton version releases in a new Steam app it needs to be added to the list: https://github.com/tkashkin/GameHub/blob/dev/src/data/compat/Proton.vala#L27 |
I see, Thanks! |
Wait, I'm confused about something. Doesn't GameHub just launch a Steam game by telling Steam to launch it via the command line? And if so, shouldn't Steam then know exactly how Proton is configured for that game, if it's being used at all, and use the correct version as if you had pressed the Play button right in Steam? Is this issue only referring to what GameHub says about Proton versions, regardless of what actually happens when it tells Steam to launch a Proton game? If yes to all of that, then I'm good. If no to all of that, then hoo boy, I don't understand how launching Proton games through GameHub is reasonable at all until this becomes a whole lot more automatic. Proton versions and also Steam's launch settings--stuff like parameters and environment variables--are extremely vital parts of getting many Proton games running in my experience. I'd like to be able to just have those set in Steam and then have GameHub blindly tell Steam to launch that game the way it knows how. |
@Jimi-James
Yes, exactly, GameHub launches Steam games via However Gamehub also supports launching non-Steam games with Proton, and in this case Steam client itself is not used at all. GameHub uses Proton builds provided by Steam (user needs to install them manually using Steam client). |
proton 4.2 is not detected for me. Its appid is 1054830 |
@jarrard it should be detected in latest GameHub version. Check:
|
The gamehub version is not specified anywhere obvious. Anyway I'm using 0.13.1.1.master-1 from the AUR and it does not detect proton 4.2 which I have been using with steam so it is 100% unpacked. $HOME/.steam/steam/steamapps/common/Proton 4.2/ : this is the location of my proton 4.2 It does detect wine32 and wine64, custom script does nothing. When I had proton 3.16 installed it showed up in the list but not proton 4.2 |
It's shown:
Proton appids are currently hardcoded and GameHub needs to be updated to use newer Proton versions. Proton 4.2 appid and many other improvements are not in |
Ahh, well that explains it, I wasn't sure if the git version was newer or not. |
f88b0a4 improves binary vdf parser so it can now read It will allow to implement automatic Proton versions detection. |
Fix Proton prefix init Add simple download speed counter Former-commit-id: 1825920
Former-commit-id: 788bb28
Former-commit-id: 34b3c90
The versions of Proton used by GameHub are hardcoded:
https://github.com/tkashkin/GameHub/blob/dev/src/data/compat/Proton.vala#L27
It's using 3.7-2 despite the last release is 3.7-8. Can we have the latest available release or at least let the user to change the appid if necessary?
The text was updated successfully, but these errors were encountered: