Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'about' section to settings for easy reference and linking #212

Closed
glaere opened this issue Mar 22, 2019 · 5 comments
Closed

Add 'about' section to settings for easy reference and linking #212

glaere opened this issue Mar 22, 2019 · 5 comments
Labels
enhancement New feature or request question Further information is requested UI

Comments

@glaere
Copy link

glaere commented Mar 22, 2019

Add an 'about' section to the settings section to make it easier to see version number of GameHub along with links to GameHub's website and GitHub.

@tkashkin
Copy link
Owner

I can add a generic GTK AboutDialog, but:

  • I have no idea where to put it. GNOME apps have an app menu, but there's no such menu in GameHub
  • I'm not sure if it's really necessary to have this dialog
Why there's no About dialog now?

GameHub was initially started as an elementary OS application and was meant to be distributed primarily through elementary AppCenter.

It's built on GTK and Granite and follows mostly elementary HIG instead of GNOME HIG.

elementary apps do not have About dialogs and Granite AboutDialog is deprecated. All of app's metadata is meant to be shown by application managers like AppCenter or GNOME Software. More in this post.

@trprado
Copy link

trprado commented Mar 22, 2019

A possibility is to add a new tab in the config with the about info. I liked the idea, and if possible put version information of app.

@tkashkin tkashkin added enhancement New feature or request question Further information is requested UI labels Mar 30, 2019
@tkashkin
Copy link
Owner

tkashkin commented Mar 30, 2019

I have tried both Gtk.AboutDialog and Granite.Widgets.AboutDialog and I don't like neither of those.

I have decided to create a custom About dialog. Here's how it looks now:
image

Do you have any feedback, did I forget to add anything important?

Also I still have no idea where to put a button to open this dialog.

@neuromancer
Copy link
Contributor

Feedback: if you want, don't forget to add you as the author of this wonderful software.
Regarding where to put this, you could make the "GameHub" title in the top-center main window clickable to open this dialog.

tkashkin added a commit that referenced this issue Mar 30, 2019
@tkashkin
Copy link
Owner

tkashkin commented Mar 30, 2019

About dialog is implemented in latest commit. Issue templates are updated to mention about dialog.

image

Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested UI
Projects
None yet
Development

No branches or pull requests

4 participants