-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages #156
Comments
@neuromancer, @hogarthj any updates on GameHub packages? |
I'm interested in AUR packages maintainership/co-maintainership, had made updated pkgbuilds for Gamehub (not online ATM), can get in touch with current AUR maintainers in the next days |
@FabioLolix Let's co-maintain the gamehub(-git) packages. My AUR username is neuromancer. Do you know the exact procedure to change the current ones? Also, can we ask ArchLinux to include a stable version of GameHub as a precompiled package? That could be great! |
My Arch build now is basically the The first two changes solves very critical issues for me, and I think The dependencies may still be outdated though, though not what I've seen. |
Update: @btd1337 updated the gamehub-git aur with my suggestions. It works well now imo. If you have AUR accounts you can help out by upvoting it, so it's more likely other users will use gamehub-git rather than the one just named gamehub |
gamehub-git was disowned by @btd1337. Now I am a primary maintainer of this package, however I don't have experience with Arch and AUR. Does anyone want to co-maintain this package? |
I don't have experience with AUR (just in Arch in general), but I should be able to help you, since I re-install that package frequently 😄 |
@neuromancer I have added you as a co-maintainer. |
Great, I just received the notification for that. |
You can add me too, I didn't have much time lately but I have some experience with the AUR |
I'm not sure there'd be a benefit to me also having that role, but don't mind helping out here. This fixes the issues I know of in You may want to change Someone also suggested changing to |
Updates coming, an orphan request for gamehub on AUR has been asked some days ago and accepted today. There will be some things to specify:
I have adopted @friday's Improved/fixed/unified the packages and things like license,arch=(), fixed link creation. Removed unnecessary custom variables While not all dependencies are listed the packages compile in a clean chroot
exists the !strip option, but what did the trick was $CFLAGS -O0
IMO, $name-git package should track master branch, while different packages should track other banches ($name-$branch-git) usually
Bad idea, because the package is compiled, |
Nice!
Perhaps. I've never seen |
@tkashkin apologies but life got in the way a bit (vacations, work and sickness ... been a busy few months) .... I'm back again now ... just did a test build and looking good with the polkit and overlay changes :) I'll update with the COPR soon and a PR that will allow RPM builds with the spec I have soon. |
RPM packages ready for OpenMandriva Cooker (upcoming Lx4) for all supported arch x86, znver1, x86_64, ARMv7hnl and aarch64. OpenMandriva users can install it via:
https://abf.openmandriva.org/openmandriva/gamehub/build_lists |
FWIW, I've put together a pretty solid package for openSUSE on OBS: https://build.opensuse.org/package/show/home:lewellyn:gamehub/gamehub I'm using it myself, so this isn't just a "it builds!" sort of thing... I have a pretty sizable library (a couple thousand games) and I've put the app I've packaged through its paces a bit, including controller support. :) At this moment, only Tumbleweed builds properly. I've been working on the build dependencies for Leap (42.3, 15.0, and 15.1) and SLE. I'm also going to try to get it building for at least one other RPM-based distro, mostly as a build canary. (If something fails for another distro, it will let me know to be wary for changes in openSUSE so I can avoid build failures.) It's set up so that I can give @tkashkin a URL to use as a GitHub webhook and it'll automatically force a new build each time there's a commit to git. 👍 Until such time as it's requested of me, I'll kick off fresh builds manually pretty often. Note that my intent with this package is to have a good, solid current-dev-git GameHub in openSUSE. I'm not unwilling to build one for current release, as well. But I see more value at the moment in testing the sharpest edges in hopes of exposing bugs, to make sure that once it ends up in actual distro packages it's as stable as can be. I'm aware of at least two other GameHub packages in OBS. I feel that mine is closer to a release-grade package at this time. I'm not here to disparage the hard work of others, so I'll not detail for posterity the issues I had with their packages. I'm quite willing to work with anyone who wants to help with making a better package and experience. Even people who use other RPM-based distros. gasp :) With enough users and feedback of this package, I'd be willing to submit my changes to the X11:Pantheon:Apps repo, in hopes of getting a distro package of GameHub (for tagged releases) once libunity is in Factory rather than only in an OBS repository. @tkashkin I can provide you a one-click install file for users to click on your project page, if you wish. Send me a message and we can work that out. :) (For those curious about the version format I chose, it's " |
Tags are created automatically by AppVeyor after each commit if build was successful. It means that #236 suggests that It also might be worth to use |
What gets lost by not including it? Considering it's in a repo that's likely to end up in Factory/Tumbleweed (similar to Debian Unstable or Fedora Rawhide), I have a preference to keep the dependency for the moment (where it's resolvable) if it creates a higher-quality app or experience.
OK. So there's a chance that if the sources are pulled in that minute or so between commit and AppVeyor's build, the tag won't reflect reality? I've stripped everything but the tag from the version now.
Sorry, I had misread the comment in the New Issue template as "compiled with optimization turned on", as I always peek in those when building something to try to make them useful if they die. :) I have resolved the build information, as well:
Unfortunately, as I lose the short hash by the time the build process starts, I am just taking the first 7 characters of the full commit hash. This is, effectively, all git is doing. :) I've run and tested the bits locally and have recently pushed them to my repo so that they will automatically build. If you have any additional feedback or requests, I'm willing to oblige to the best of my ability. 👍 I'd also be interested in feedback from those packaging for other RPM distros. I haven't taken the time to really look at the other specs yet; just enough to sanity check that I was doing approximately the correct thing. |
Nothing too important. Now it's used to implement a list of favorite games, download progress and current downloads counter on launchers/docks/etc. It's nice to have it if available but it's not required:
Yes, tag won't be updated before build finishes successfully. Tag format now is |
Hm. The tags I'm seeing in the repo are |
Isn't using Recommends an option? |
@vhda no, all dependencies need to be listed in |
I have decided to remove
In future I plan to remove it entirely or use/backport |
|
@tkashkin ( @FabioLolix, @neuromancer ) is it possible to remove the libunity from the dependences from the AUR gamehub-git? or just make it as optional dependence. Right now, it's not possible to compile the libunity due to an incompatibility with the latest version of vala (I had to downgrade the vala to compile it) |
I'll be on it soon today
Il dom 16 giu 2019, 13:39 Henrique Lechner <[email protected]> ha
scritto:
… @tkashkin <https://github.com/tkashkin> ( @FabioLolix
<https://github.com/FabioLolix>, @neuromancer
<https://github.com/neuromancer> ) is it possible to remove the libunity
from the dependences from the AUR gamehub-git? or just make it as optional
dependence.
Right now, it's not possible to compile the libunity due to an
incompatibility with the latest version of vala (I had to downgrade the
vala to compile it)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#156?email_source=notifications&email_token=AEV2OT7ZVRAW4B7OKO3GRE3P2YRAZA5CNFSM4GL57MD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZLDCQ#issuecomment-502444426>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEV2OTZ63LCOVQHYC7ETA7LP2YRAZANCNFSM4GL57MDQ>
.
|
Let me reinstall it here to confirm this.. |
You are right, libunity cannot be (re)installed:
|
I think it should be solved now. |
|
not sure if this is the place to go with this, But ive been trying to build a package for my distro named crux. which can be found at https://crux.nu . While compiling the package it seems to get stuck forever with the following message : |
@Ergo0 that's not helpful. Can you provide full build log? |
@tkashkin So i tried to pipe the buildlog into a textfile and also tried to upload the output through wgetpaste. the problem seems to be that the build gets stuck on a loop. this is the buildlog before the error message i just posted : https://bpaste.net/show/259fd7e8f893 which basically keeps repeating itself as if its stuck in a loop. |
@Ergo0 this is not related to GameHub. Something goes wrong while compiling |
@Ergo0 @tkashkin I went ahead and created some missing ports, this works for me |
It would be nice if |
I'm interested to package this for Debian. However, do you really need the |
@stephanlachnit Thanks for help. I've packaged it a long time ago and I didn't research Debian packaging guidelines deep enough, so it's definitely not a good package. Some of the issues you've listed come from elementary packaging guidelines because initially GameHub targeted primarily elementary OS.
Yes, I agree. It will slightly complicate CI scripts, but I planned to rewrite them anyway. |
Another things I noticed: it looks like you bundle libs for flatpak. Can you avoid this and download them when building instead? (iirc this is easily possible) |
@stephanlachnit Does it matter even if these libs are not used by debian package? Would moving them to a separate branch or repo be enough if it matters? I plan to rewrite flatpak in future anyway and flatpak-specific files will likely be in a separate branch as well as |
Is there a possibility of adding GameHub once again to Flathub? Lutris is already there on the beta channel. |
It depends. It does matter if it's inside the source package. Usually we just use the autogenerated one from github when a version is tagged. These tarball include the entire repo, so yes that would be a problem. |
@Saroufim I will try if I can fix existing issues. |
@stephanlachnit I'll move them to a separate branch. |
When installing the flatpak bundle from the releases page, I had to run with
This is with flatpak 1.10 on Debian buster-backports |
Debian/Ubuntu-based distros
Other distros
The text was updated successfully, but these errors were encountered: