Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Badge and Progress support for an Application #288

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Provide Badge and Progress support for an Application #288

merged 5 commits into from
Jul 8, 2019

Conversation

tintou
Copy link
Member

@tintou tintou commented Jun 2, 2019 •
edited
Loading

It is usign the same DBus API as libunity and is here to replace the tiny part that we are still using.
Fixes #287

@tintou tintou changed the title Provide Badge and Progress support for an Application. Provide Badge and Progress support for an Application Jun 2, 2019
Provide Badge and Progress support for an Application.
c3b1702 
It is usign the same DBus API as libunity and is here to replace the tiny part that we are still using.
donadigo
donadigo requested changes Jun 2, 2019
View reviewed changes
Copy link
Collaborator

@donadigo donadigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have come diff comments.
Also one question: do you know what package / service provides /com/canonical/unity/? Or is there even a need for it to be provided at all by unity?

lib/Services/Application.vala Show resolved Hide resolved
demo/Views/ApplicationView.vala Show resolved Hide resolved
demo/Views/ApplicationView.vala Show resolved Hide resolved
demo/Views/ApplicationView.vala Show resolved Hide resolved
demo/Views/ApplicationView.vala Show resolved Hide resolved
@tintou
Copy link
Member Author

tintou commented Jun 2, 2019

Have come diff comments.
Also one question: do you know what package / service provides /com/canonical/unity/? Or is there even a need for it to be provided at all by unity?

We are registering this path here by the application so there is no need for any extra package, the dock is responsible for watching to the addition/removal of interfaces

@tkashkin tkashkin mentioned this pull request Jun 7, 2019
Open
donadigo
donadigo approved these changes Jul 3, 2019
View reviewed changes
Copy link
Collaborator

@donadigo donadigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@danirabbit danirabbit merged commit bebf1ed into master Jul 8, 2019
@danirabbit danirabbit deleted the tintou/unity branch July 8, 2019 14:45
@danirabbit danirabbit added this to the 5.2.5 milestone Jul 8, 2019
jmc-88 pushed a commit to jmc-88/granite that referenced this pull request Jul 8, 2019
@jmc-88
Provide Badge and Progress support for an Application (elementary#288)
8b7e79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw left review comments

@donadigo donadigo donadigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.5
Development

Successfully merging this pull request may close these issues.

Provide the missing bits from libunity
4 participants
@tintou @donadigo @jeremypw @danirabbit