-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add axum_core::body::Body
#1584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Nov 27, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 12, 2023
davidpdrsn
added a commit
that referenced
this pull request
Feb 16, 2023
davidpdrsn
added a commit
that referenced
this pull request
Feb 20, 2023
davidpdrsn
added a commit
that referenced
this pull request
Feb 24, 2023
davidpdrsn
added a commit
that referenced
this pull request
Feb 27, 2023
davidpdrsn
added a commit
that referenced
this pull request
Mar 10, 2023
davidpdrsn
added a commit
that referenced
this pull request
Mar 10, 2023
davidpdrsn
added a commit
that referenced
this pull request
Mar 17, 2023
davidpdrsn
added a commit
that referenced
this pull request
Mar 20, 2023
davidpdrsn
added a commit
that referenced
this pull request
Mar 23, 2023
davidpdrsn
added a commit
that referenced
this pull request
Apr 21, 2023
davidpdrsn
added a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work towards 0.7.0
Hyper 1.0 is moving
hyper::Body
tohyper-util
. That crate isn't stable so I don't think we should have it in axum's public API. This PR adds our own body type that just wraps another boxed body that we can use instead. It just adds the new type and doesn't actually use it yet. I'll do that in follow up PRs.Generally my thinking is to replace
Service
impls with:So receive any boxable body but internally always use
axum_core::Body
. This means things don't need to be generic the request body which should be more ergonomic and fix issues such as #1110axum_core::Body
will also be re-exported ataxum::body::Body
for 0.7.0 but didn't do that here.