-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.7.0 #1583
v0.7.0 #1583
Conversation
|
|
I'm a little confused about the first sentence of your reply, but the rest makes sense ^^ |
Also, are you working on upgrading axum to the rc's? If you could use some help, I'm interested in looking into (parts of) that. |
Not right now. I'm mostly doing small prep things. Also have a PR in the works for a simple server function that uses hyper 1.0-rc.1. You're very welcome to help out! Its not quite clear to me if we even can update to hyper rc.1 as there might be some things missing. But attempting to update is probably the best way to figure that out 😅 |
842f22a
to
14ad346
Compare
fc1a10f
to
813dbac
Compare
46fa940
to
7facc0f
Compare
Co-authored-by: David Pedersen <[email protected]>
Co-authored-by: Jonas Platte <[email protected]> Co-authored-by: Michael Scofield <[email protected]>
Co-authored-by: Jonas Platte <[email protected]> Co-authored-by: Michael Scofield <[email protected]>
Co-authored-by: Michael Scofield <[email protected]> Co-authored-by: Jonas Platte <[email protected]>
I'm leaning towards merging this and making a Looking at the issues there aren't any big features remaining that need to be implemented in 0.6 first. So cherry-picking to a |
I wanna start slowly working towards 0.7.0. The biggest change for that will be hyper 1.0 compatibility.
Other PRs for 0.7.0 should be merged into this one. Think we should keep
main
free of breaking changes for a bit.Some things off the top of my head we need (might file separate issues on these):
hyper::Server
,http_body::Full
,http_body::Empty
, and possibly others. Those are being moved to*-util
crates which will have breaking changes so we shouldn't have them in our public API.axum::serve(addr, make_service)
function. I think our recommended server should be the one inhyper-util
. However I also think we should provide a very simple server function for "hello world" stuff. I think that should just be a single function without any configuration.hyper::Body
is going away and it is using a newIncoming
which is much smaller in scope. I think this could lead to much improved ergonomics and perhaps we could even remove the genericB
type everywhere (related to Middleware that change the request body have poor usability #1110)422 Unprocessable Entity
forForm
deserialization errors, exceptGET
andHEAD
requests #1683 (comment)Sync
for services (Enforce Sync for inner services and handlers #1477)?Body
handle errors?Full
andEmpty
from public API (I know they're at least in axum-core)serve
handle both http 1 and 2?