Use 422 Unprocessable Entity for Form deserialization errors, except GET and HEAD requests
#1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserialization errors for `Form` previously always used `400 Bad Request`. However that should apply for `GET` requests. `POST` etc. should use `422`. Fixes #1680
davidpdrsn
changed the title
422 Unprocessable Entity for form deserialization errors422 Unprocessable Entity for Form deserialization errors, except GET requests
davidpdrsn
changed the title
422 Unprocessable Entity for Form deserialization errors, except GET requests422 Unprocessable Entity for Form deserialization errors, except GET and HEAD requests
jplatte
approved these changes
Jan 16, 2023
| @@ -104,6 +112,7 @@ composite_rejection! { | |||
| pub enum FormRejection { | |||
| InvalidFormContentType, | |||
| FailedToDeserializeForm, | |||
There was a problem hiding this comment.
This should have a Query prefix then in the next breaking-change release, I guess?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
GETandHEADrequestsFormshould use400 Bad Request(422is only for request bodies).Fixes #1680
TODO
Formto mention that it handles both query and body params.