Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the console in alacritty blocks selections and copy-paste #167

Closed
meithecatte opened this issue Sep 24, 2021 · 2 comments · Fixed by #222
Closed

Running the console in alacritty blocks selections and copy-paste #167

meithecatte opened this issue Sep 24, 2021 · 2 comments · Fixed by #222
Labels
C-console Crate: console. S-bug Severity: bug

Comments

@meithecatte
Copy link

My guess is that the terminal is led to believe that a mouse-supporting application is running. I'm not aware of any mouse features in the tokio console, though.
@hawkw
Copy link
Member

hawkw commented Sep 24, 2021

Yeah, I think that tui does this by default. I'd like to add mouse support in the future, but until then, we should probably figure out how to not make it do that...

hawkw added a commit that referenced this issue Dec 17, 2021
@hawkw
fix(console): don't enable crossterm mouse capture
3611b9f 
Currently, the console captures mouse input, but it doesn't actually do
anything with mouse input yet. This is a shame, because it means you
can't do things like copying and pasting text out of the console.

This commit disables mouse capture.

In the future, if we add mouse support to the UI, we can re-enable mouse
capture...but it would be nice to make sure copying and pasting still
works (we may have to reimplement it?).

Fixes #167
@hawkw hawkw mentioned this issue Dec 17, 2021
Merged
@hawkw
Copy link
Member

hawkw commented Dec 17, 2021

#222 should fix this!

@hawkw hawkw added C-console Crate: console. S-bug Severity: bug labels Dec 17, 2021
pnkfelix pushed a commit that referenced this issue Dec 17, 2021
@hawkw
fix(console): don't enable crossterm mouse capture (#222)
e020d66 
Currently, the console captures mouse input, but it doesn't actually do
anything with mouse input yet. This is a shame, because it means you
can't do things like copying and pasting text out of the console.

This commit disables mouse capture.

In the future, if we add mouse support to the UI, we can re-enable mouse
capture...but it would be nice to make sure copying and pasting still
works (we may have to reimplement it?).

Fixes #167
hawkw added a commit that referenced this issue Jan 18, 2022
@hawkw
console: prepare to release v0.1.1
caeb74d 
<a name=""></a>
##  (2022-01-18)

#### Features

*  feature-flag `tracing-journald` dependency (#250) ([24f25db](24f25db))
*  add vi style keybinds for tables (#223) ([1845c99](1845c99))

#### Bug Fixes

*  fix task lookup in async ops view (#257) ([9a50b63](9a50b63))
*  don't make details requests with rewritten IDs (#251) ([4ec26a8](4ec26a8))
*  fix build error with journald enabled ([a931b7e](a931b7e))
*  increase default event buffer capacity a bit (#235) ([0cf0aee](0cf0aee))
*  wrap controls line when the terminal is too narrow (#231) ([ef41507](ef41507))
*  don't enable crossterm mouse capture (#222) ([e020d66](e020d66), closes [#167](167))
hawkw added a commit that referenced this issue Jan 18, 2022
@hawkw
console: prepare to release v0.1.1 (#261)
58461bf 
<a name=""></a>
##  (2022-01-18)

#### Features

*  feature-flag `tracing-journald` dependency (#250) ([24f25db](24f25db))
*  add vi style keybinds for tables (#223) ([1845c99](1845c99))

#### Bug Fixes

*  fix task lookup in async ops view (#257) ([9a50b63](9a50b63))
*  don't make details requests with rewritten IDs (#251) ([4ec26a8](4ec26a8))
*  fix build error with journald enabled ([a931b7e](a931b7e))
*  increase default event buffer capacity a bit (#235) ([0cf0aee](0cf0aee))
*  wrap controls line when the terminal is too narrow (#231) ([ef41507](ef41507))
*  don't enable crossterm mouse capture (#222) ([e020d66](e020d66), closes [#167](167))
hawkw added a commit that referenced this issue Jan 18, 2022
@hawkw
console: prepare to release v0.1.1 (#261)
5ba3f94 
<a name=""></a>
##  (2022-01-18)

#### Features

*  feature-flag `tracing-journald` dependency (#250) ([24f25db](24f25db))
*  add vi style keybinds for tables (#223) ([1845c99](1845c99))

#### Bug Fixes

*  fix task lookup in async ops view (#257) ([9a50b63](9a50b63))
*  don't make details requests with rewritten IDs (#251) ([4ec26a8](4ec26a8))
*  fix build error with journald enabled ([a931b7e](a931b7e))
*  increase default event buffer capacity a bit (#235) ([0cf0aee](0cf0aee))
*  wrap controls line when the terminal is too narrow (#231) ([ef41507](ef41507))
*  don't enable crossterm mouse capture (#222) ([e020d66](e020d66), closes [#167](167))
hawkw added a commit that referenced this issue Jan 18, 2022
@hawkw
console: prepare to release v0.1.1 (#261)
25b80ce 
<a name=""></a>
##  (2022-01-18)

#### Features

*  feature-flag `tracing-journald` dependency (#250) ([24f25db](24f25db))
*  add vi style keybinds for tables (#223) ([1845c99](1845c99))

#### Bug Fixes

*  fix task lookup in async ops view (#257) ([9a50b63](9a50b63))
*  don't make details requests with rewritten IDs (#251) ([4ec26a8](4ec26a8))
*  fix build error with journald enabled ([a931b7e](a931b7e))
*  increase default event buffer capacity a bit (#235) ([0cf0aee](0cf0aee))
*  wrap controls line when the terminal is too narrow (#231) ([ef41507](ef41507))
*  don't enable crossterm mouse capture (#222) ([e020d66](e020d66), closes [#167](167))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-console Crate: console. S-bug Severity: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(console): don't enable crossterm mouse capture tokio-rs/console
2 participants
@hawkw @meithecatte