Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subscribe::Filter for Option<Filter> #2407

Merged
merged 16 commits into from
Sep 28, 2023

Commits on Dec 7, 2022

  1. Fully implement Filter for Box<Filter>

    Pass all the Filter methods through to the underlying Box/Arc Filter
    rather than relying on default implementations.
    jsgf committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    8919fa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Implement Filter for Option<F: Filter>

    Where None means "no filtering".
    jsgf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    00e304b View commit details
    Browse the repository at this point in the history
  2. Add test for Option<Filter> on subscribers

    Make sure None lets everything through.
    jsgf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5540321 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38f5416 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. review comment fixes

    jsgf committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    74f94ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bca61af View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. address more review comments

    jsgf committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b447e17 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Add tests and tweak None filter interest level

    * Added tests for max level filtering and interest caching with
    multiple subscribers.
    * Changed the interest level for a `None` filter from `sometimes`
    to `always` so other filters can be cached more effectively.
    ryanthomasjohnson committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7a6bb31 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge pull request #1 from ryanthomasjohnson/ryantj/option-layer-filter

    Add tests and tweak `None` filter interest level
    jsgf authored May 1, 2023
    Configuration menu
    Copy the full SHA
    8568d96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b7b671 View commit details
    Browse the repository at this point in the history
  3. Run cargo fmt

    jsgf committed May 1, 2023
    Configuration menu
    Copy the full SHA
    59cba8c View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Configuration menu
    Copy the full SHA
    dfd857a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    29d15d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Fix clippy warning

    jsgf committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    883c594 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    01be443 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    6507da9 View commit details
    Browse the repository at this point in the history