Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not save original geometry in each state #140

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Do not save original geometry in each state #140

merged 1 commit into from
Mar 31, 2019

Conversation

Fro-Z
Copy link
Collaborator

@Fro-Z Fro-Z commented Mar 31, 2019

Reduces snapshot size, speeds up loading.

@tomasiser tomasiser mentioned this pull request Mar 31, 2019
Closed
14 tasks
hojdars
hojdars approved these changes Mar 31, 2019
View reviewed changes
Copy link
Collaborator

@hojdars hojdars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why this got deleted:

static const int VERTICES_PER_UNIT_CIRCLE = 50;
static const int MIN_VERTICES_IN_CIRCLE = 12;

But the saving only colors is sound. Approved.

@Fro-Z Fro-Z merged commit c9909dc into master Mar 31, 2019
@Fro-Z Fro-Z deleted the luis/improvements branch March 31, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hojdars hojdars hojdars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fro-Z @hojdars