Accumulator mods #104
Open
Accumulator mods #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2014 16:38
… to label and show the value explicitly on the graph
|
Hi @AndrewClarke ! Thanks for the pull request. Could you add a test that uses the new feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also made two changes to Accumulator bar
1/ the ability to set the label string for the accululator
This one is a no-brainer - it just required a defaulted attribute and an attr_accessor.
2/ the ability to set a non-zero starting point for the accumulator series.
The way I've organised it, it is possible to either quietly start with a non-zero accumulator, or draw attention to it with it's own label and colour.
Firstly, the carry_forward= accessor allows the carry-forward value to be set. This value is used as a seed for for running summation across the data series.
Secondly, IF the carry_forward_label= accessor is used to provide a string, then a distinct data set is added to the graph. Most of the values of this data set are set to zero except the first item which has the carry_forward value. The carry-forward value is also subtracted from the first entry of the accumulator series. Then the carry-forward series is pushed into the graph - it will pick it's own colour and show the label in the legend.