iostream: Resolve pending reads on stream close #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue that a read may fail with StreamClosedError if stream is closed mid-read
_start_read can resolve with _try_inline_read, which can succeed even if the stream has been closed if the buffer has been populated by a prior read preserve the fix for asserts being hit when dealing with closed sockets
bdarnell
force-pushed
the
resolve-pending
branch
from
af315dc
to
238110b
Compare
|
Hi, @bdarnell We have this problem randomly in product (single thread with multiple request concurrent). Should the MR merge to v6.0.4 at the same time? thanks. |
|
Yeah, this should probably be backported to 6.0.x. But since this issue (and the related #2651) have proven so difficult to test I'd like to get reports from people who have tested this change in other releases (either from master or in 6.1 when that comes out) before I put it in a patch 6.0.x release. Have you tried master? Does it work for you? |
|
Sorry for delay. There is no "Stream Closed" error after apply this patch so far. It works well for me. |
|
Thanks for testing! I've decided to get this in to 6.0.4, which I'm preparing in #2819. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes code from #2719 and tests from #2720.
Fixes two bugs related to interactions between reads and closes:
Fixing the latter issue narrowed the scope of the change introduced in #2670, so we should watch for a recurrence of #2651. We haven't been able to construct good test cases for #2651 or the second issue fixed here; the timing required is subtle (although we have non-unittest reproductions).
Closes #2717
Closes #2719
Closes #2720