Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iostream: Resolve pending reads on stream close #2805

Merged
merged 5 commits into from
Feb 1, 2020
Merged

iostream: Resolve pending reads on stream close #2805

merged 5 commits into from
Feb 1, 2020

Commits on Feb 1, 2020

  1. iostream: resolve reads that may be completed while closing 

    fixes issue that a read may fail with StreamClosedError
if stream is closed mid-read
    @minrk @bdarnell
    minrk authored and bdarnell committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    a772ed9 View commit details
    Browse the repository at this point in the history

  2. avoid premature _check_closed in _start_read 

    _start_read can resolve with _try_inline_read, which can succeed even if the stream has been closed
if the buffer has been populated by a prior read

preserve the fix for asserts being hit when dealing with closed sockets
    @minrk @bdarnell
    minrk authored and bdarnell committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    deed964 View commit details
    Browse the repository at this point in the history

  3. catch UnsatisfiableReadError in close

    @minrk @bdarnell
    minrk authored and bdarnell committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    a429005 View commit details
    Browse the repository at this point in the history

  4. iostream: Add tests for behavior around close with read_until 

    Updates #2719
    @bdarnell
    bdarnell committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    b0d495e View commit details
    Browse the repository at this point in the history

  5. iostream: Expand comments around recent subtle changes

    @bdarnell
    bdarnell committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    238110b View commit details
    Browse the repository at this point in the history