Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul dependencies #51

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Conversation

da2ce7
Copy link

@da2ce7 da2ce7 commented Aug 8, 2024

closes: #19, closes: #20, closes #21, closes: #22, closes: #23, closes: #25

Todo:

  • Update Readme

@da2ce7 da2ce7 force-pushed the 20240725_update_deps branch 2 times, most recently from 4c51bec to 632b1e8 Compare August 10, 2024 17:35
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 32.97194% with 2102 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@0b9ca27). Learn more about missing BASE report.

Files Patch % Lines
packages/dht/src/worker/handler.rs 0.00% 496 Missing ⚠️
examples/simple_torrent/src/main.rs 0.00% 336 Missing ⚠️
packages/dht/src/worker/lookup.rs 0.00% 141 Missing ⚠️
examples/get_metadata/src/main.rs 0.00% 137 Missing ⚠️
packages/dht/src/worker/bootstrap.rs 0.00% 129 Missing ⚠️
packages/peer/src/message/mod.rs 0.00% 122 Missing ⚠️
packages/peer/src/message/prot_ext/mod.rs 0.00% 58 Missing ⚠️
packages/peer/src/manager/sink.rs 46.60% 55 Missing ⚠️
packages/disk/src/disk/tasks/mod.rs 58.41% 42 Missing ⚠️
packages/dht/src/worker/refresh.rs 0.00% 39 Missing ⚠️
... and 57 more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #51   +/-   ##
==========================================
  Coverage           ?   59.80%           
==========================================
  Files              ?      153           
  Lines              ?    12718           
  Branches           ?        0           
==========================================
  Hits               ?     7606           
  Misses             ?     5112           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da2ce7
Copy link
Author

da2ce7 commented Aug 10, 2024

@josecelano , not (yet) ready to review, however now all tests pass and all the dependencies have been upgraded :)

@da2ce7 da2ce7 mentioned this pull request Aug 11, 2024
da2ce7 added a commit that referenced this pull request Aug 11, 2024
7badfca refactor: rename uber to uber/mod (Cameron Garnham)
62efa22 refactor: peer manager, sink, stream, messages and fused (Cameron Garnham)
a930df5 refactor: disk manager sink, stream and builder (Cameron Garnham)
863536e refactor: handshake sink, stream and builder (Cameron Garnham)
672b869 refactor: move tests into tests folder (Cameron Garnham)
3706d77 clippy: fix unneeded match in filters.rs (Cameron Garnham)

Pull request description:

  Allowing for better review of #51

ACKs for top commit:
  da2ce7:
    ACK 7badfca

Tree-SHA512: a82af990f2d6d3ce2eb66ec059b005e9b420b8b19878bbc7d8e7d641e7b0a551bdf1858c0d8f9497ec44db1907e35ad9e7bb6e43ba83bb78bf9dc01a9f2f2557
@da2ce7 da2ce7 changed the title Update all deps to latest versions. overhaul dependencies Aug 11, 2024
@da2ce7 da2ce7 marked this pull request as ready for review August 11, 2024 12:49
@da2ce7 da2ce7 force-pushed the 20240725_update_deps branch 3 times, most recently from e0ad2fb to cb2e84d Compare August 21, 2024 11:31
@da2ce7
Copy link
Author

da2ce7 commented Aug 21, 2024

@josecelano this pull request is ready for review now :)

@da2ce7
Copy link
Author

da2ce7 commented Aug 24, 2024

ACK f889ad6

@da2ce7 da2ce7 merged commit 24c4707 into torrust:develop Aug 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deps: Update Tokio Deps: Update Futures Deps: Update Nom Deps: Update Mio Deps: Update Clap
2 participants