Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Refactor for Project #52

Merged
merged 6 commits into from
Aug 11, 2024
Merged

Conversation

da2ce7
Copy link

@da2ce7 da2ce7 commented Aug 11, 2024

Allowing for better review of #51

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 65.67797% with 162 lines in your changes missing coverage. Please review.

Project coverage is 62.44%. Comparing base (f3c71f8) to head (7badfca).

Files Patch % Lines
packages/peer/src/manager/sink.rs 56.14% 50 Missing ⚠️
packages/handshake/src/handshake/mod.rs 17.07% 34 Missing ⚠️
packages/peer/src/manager/stream.rs 50.94% 26 Missing ⚠️
packages/handshake/src/handshake/builder.rs 60.60% 13 Missing ⚠️
packages/disk/src/disk/manager/sink.rs 68.57% 11 Missing ⚠️
packages/handshake/src/handshake/sink.rs 52.17% 11 Missing ⚠️
packages/select/tests/select_tests.rs 94.49% 6 Missing ⚠️
packages/handshake/src/handshake/stream.rs 0.00% 5 Missing ⚠️
packages/disk/src/disk/manager/mod.rs 88.88% 3 Missing ⚠️
packages/disk/src/disk/manager/stream.rs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #52      +/-   ##
===========================================
+ Coverage    59.72%   62.44%   +2.72%     
===========================================
  Files          135      147      +12     
  Lines        11342    11432      +90     
===========================================
+ Hits          6774     7139     +365     
+ Misses        4568     4293     -275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da2ce7
Copy link
Author

da2ce7 commented Aug 11, 2024

ACK 7badfca

@da2ce7 da2ce7 merged commit 0b9ca27 into torrust:develop Aug 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants