#205 Wrong downloaded torrent file name #246
Conversation
|
torrust/torrust-index-types-lib Needs to be updated, and package.json has to reflect that change before submitting the PR for review. |
| @@ -43,4 +43,4 @@ | |||
| "torrust-index-types-lib": "^0.2.0", | |||
| "uuid": "^9.0.0" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
no need to edit this file (removing the trailing newline)
There was a problem hiding this comment.
Fixed with new commit.
There was a problem hiding this comment.
Hi @mario-nt, in general, I prefer to rewrite the PR commits instead of revert changes if they are not merged yet. Just to have the history as clean and straightforward as possible.
There was a problem hiding this comment.
Hi @josecelano, I thought about that too and wasn't sure about wich approach to take. I will go and modify the commits as I think too, it creates a clearer commit history.
mario-nt
force-pushed
the
205-wrong-downloaded-torrent-file-name
branch
from
c67842c
to
8788eee
Compare
…e name Now, when the user downloads a torrent file, that file is named after the torrent name instead of the torrent title. The parameter torrent.title was replaced by torrent.name in every call to the function that handles the download of the torrent file.
mario-nt
force-pushed
the
205-wrong-downloaded-torrent-file-name
branch
from
8788eee
to
5281ceb
Compare
…the name Updated packages so now they contain the name of the torrent in the responses from the API calls and the typescript types.
|
Rebase and tests OK @josecelano, Dependencies updated too. |
Cool! Thank you! |
|
ACK c097875 |
Fixes #205