Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#205 Wrong downloaded torrent file name #246

Merged
merged 2 commits into from
Sep 15, 2023
Merged

#205 Wrong downloaded torrent file name #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5281ceb
fix: [#205] downloaded torrent file's name is the title not the name
Sep 4, 2023
c097875
build: [#205] downloaded torrent file's name is the title not the name
Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/torrent/TorrentActionCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@

<div class="flex flex-row gap-3">
<template v-if="showDownloadButtons">
<button class="btn btn-primary grow" data-cy="torrent-action-download" @click="downloadTorrent(torrent.info_hash, torrent.title)">
<button class="btn btn-primary grow" data-cy="torrent-action-download" @click="downloadTorrent(torrent.info_hash, torrent.name)">
download torrent
</button>
<button class="w-12 p-0 btn btn-primary">
Expand Down
2 changes: 1 addition & 1 deletion components/torrent/TorrentList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<div class="flex flex-row font-semibold text-center flex-nowrap rounded-2xl">
<div class="flex flex-col justify-center w-10 h-10 text-green-500 shrink-0 rounded-2xl">{{ torrent.seeders }}</div>
<div class="flex flex-col justify-center w-10 h-10 ml-2 text-red-500 shrink-0 rounded-2xl">{{ torrent.leechers }}</div>
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0 rounded-2xl" @click.stop="downloadTorrent(torrent.info_hash, torrent.title)">
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0 rounded-2xl" @click.stop="downloadTorrent(torrent.info_hash, torrent.name)">
<ArrowDownTrayIcon class="w-6" />
</div>
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0 rounded-2xl">
Expand Down
2 changes: 1 addition & 1 deletion components/torrent/TorrentTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</td>
<td>
<div class="flex flex-row items-center justify-center font-semibold flex-nowrap">
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0" @click.stop="downloadTorrent(torrent.info_hash, torrent.title)">
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0" @click.stop="downloadTorrent(torrent.info_hash, torrent.name)">
<ArrowDownTrayIcon class="w-5" />
</div>
<div class="flex flex-col items-center justify-center w-10 h-10 ml-2 duration-500 cursor-pointer text-base-content/50 hover:text-base-content shrink-0">
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
"dompurify": "^3.0.5",
"marked": "^7.0.2",
"notiwind-ts": "^2.0.2",
"torrust-index-api-lib": "^0.2.0",
"torrust-index-types-lib": "^0.2.0",
"torrust-index-api-lib": "^1.0.0-alpha.1",
"torrust-index-types-lib": "^1.0.0-alpha.1",
"uuid": "^9.0.0"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to edit this file (removing the trailing newline)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with new commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mario-nt, in general, I prefer to rewrite the PR commits instead of revert changes if they are not merged yet. Just to have the history as clean and straightforward as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josecelano, I thought about that too and wasn't sure about wich approach to take. I will go and modify the commits as I think too, it creates a clearer commit history.