Decoupling services from actix-web framework.

Decoupling services from actix-web framework.

Decoupling services from actix-web framework.

5396301 refactor: [#157] extract authentication service (Jose Celano)
8101048 refactor: [#157] extract service to ban users (Jose Celano)
2eb0f7c refactor: [#157] extract service for user registration (Jose Celano)
1abcc4d refactor: [#157] extract service: torrent (Jose Celano)
0387b97 refactor: [#157] extract service: settings (Jose Celano)
c9fb249 refactor: [#157] extract service: proxy (Jose Celano)
d58f3cc refactor: [#157] extract service: category (Jose Celano)
baa4c7e refactor: [#157] extract service: about (Jose Celano)

Pull request description:

  - [x] Extract `about` service.
  - [x] Extract `category` service.
  - [x] Extract `proxy` service.
  - [x] Extract `settings` service.
  - [x] Extract `torrent` service.
  - [x] Extract `user` registration service.
  - [x] Extract `user` ban service.
  - [x] Extract `user` authentication service.

ACKs for top commit:
  josecelano:
    ACK 5396301

Tree-SHA512: b63a45f3eb8aaab0d51c885793c94e85979273128d9cb94e36a4ed7577a399105e9dcef9624077b4ae07c8aac03f6520eb1823944e2b44554d1bd85ad8c9e281

9ca7341 docs(api): [#163] API documentation on docs.rs (Jose Celano)

Pull request description:

  API documentation on [docs.rs](https://docs.rs/torrust-index-backend).

  API Contexts:

  - [x] `about`
  - [x] `category`
  - [x] `proxy`
  - [x] `settings`
  - [x] `torrent`
  - [x] `user`

ACKs for top commit:
  josecelano:
    ACK 9ca7341

Tree-SHA512: a630056d9d9ce6e21f60538e1fdaabfb3c3fc1efd23e2d4e03408b0a32711a8f75d2b154d5b70a211e93d944f7a8386cb851b48cae593e45a3fc11df1763aef7

9baedfb docs: [#166] installation and configuration (Jose Celano)

Pull request description:

  Move installation and configuration docs to Rust [Documentation Comments](https://doc.rust-lang.org/book/ch14-02-publishing-to-crates-io.html#making-useful-documentation-comments).

Top commit has no ACKs.

Tree-SHA512: 4667d630446b45e1b73485f8c64b0dc4aa59e980aa4896f96b77dff9c13a1e84b5308428fd8ffa00708b1500401ab0c52cce96ecf08e26abd99c96a3ac8b9b91

5485589 refactor: remove unneeded code (Jose Celano)
93d1b64 docs: [#168] statistics importer console command (Jose Celano)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 1d5f8b787ae94b418aaea50bee045fa080f8b200cac1f22e514c8a9a4c3548d504f9c92a1eabbc4658530522d798a139ea07d6f012d3167cc70728f0e921f322

Documentation for the command to upgrade the application.

d7f51fa docs: [#169] app upgrader documentation (Jose Celano)

Pull request description:

  Documentation for the command to upgrade the application.

Top commit has no ACKs.

Tree-SHA512: 1c1aa1876fe28836a12c77ff7a76f5877dd443fd98f12ffd3d2ddc603f73dec7776b120370a5ddf8039f98b8c4f272e769a4aa4f24d67f42c02ce0bcad57b660

We decided to migrate from Actix Web to Axum. The main reason was we are
also using Axum on the Tracker and it will be easier for us to mantain
only one framework. And apparently there are no drawbacks.

This commit adds the new dependencies.

When the loggin level is set to INFO sqlx logs all SQL statements like
this:

```
2023-06-06T17:19:52.639651375+01:00 [sqlx::query][INFO] SELECT version FROM _sqlx_migrations …; rows affected: 0, rows returned: 0, elapsed: 58.361µs

SELECT
  version
FROM
  _sqlx_migrations
WHERE
  success = false
ORDER BY
  version
LIMIT
  1
```

This commits makes sqlc to log only failed statements as errors and slow
statements (>1 second) as warnings.

Basic changes needed to run the Axum API implementation in parallel with the current one with ActixWeb.

For the time being, we will be only useinf the Auxm implementation for testing until all endpoints are migrated.

d08f70e refactor(api): [#174] Axum API scaffolding (Jose Celano)
7bcf20e feat: disable sqlx logging for all statements (Jose Celano)
7347fee feat(api): [#174] new cargo dependencies: axum, hyper (Jose Celano)

Pull request description:

  Basic changes which are needed to run the Axum API implementation in parallel with the current one with ActixWeb. For the time being the Axum implementation will be only used for testing until all endpoints are migrated.

Top commit has no ACKs.

Tree-SHA512: 6d0b8ed20329e91ba92bf5d78caf366b1fb61c2048040154b68da876878cd73f5de372be0955c492b82f307cbe8786d702ce86dbfa201900d6d98ea1913ba85b

3edd507 docs: [#97] update README (Jose Celano)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: cb0002a0733e9ae5e2648d3bff3ad0fbb020f385caec68b77fac74f54af249504fd9e8ad4ff499e223bbdc8f653061b8916580ed7ea51d077c1e057e358b93c0

```toml
log_level = "info"
```

The level can be:

- `off`
- `error`
- `warn`
- `info`
- `debug`
- `trace`

The log has some errors we need to fix. See:

#176

68e2132 refactor: disable logging for testing (Jose Celano)
0264e5c feat: [#177] new config option for log level (Jose Celano)

Pull request description:

  ```toml
  log_level = "info"
  ```

  The level can be:

  - `off`
  - `error`
  - `warn`
  - `info`
  - `debug`
  - `trace`

  It's optional. The default value is `info`.

Top commit has no ACKs.

Tree-SHA512: 7bb55827fefa093bf5a64295047fe237b23e76c239c9385793a73e11570e1eecd73d5c07e09625ac5d4236a46f149bff0ff462d3b54779cd836bbe3921a8232b

1924365 refactor(api): [#178] axum API, 'about' context migrated (Jose Celano)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: bfa8d3ce6b1d5f59fdf6f35619c0e0a552ce49df7a9cb89081dc7f29e3f6dfb18216dde9c722e3f3610079987dcc68664c062eaff4c7d3948ff9aa243d1add56

4730afd chore: clippy errors (Warm Beer)
a6cf184 chore: cargo fmt (Warm Beer)
4286ba9 feat: added filtering torrents on tags (Warm Beer)
a1bd92f fix: sql queries (Warm Beer)
7ce3d5e feat: torrent tags (Warm Beer)

Pull request description:

See #157.

f693a02 refactor: [#187] extract tag::Service (Jose Celano)
b97698a test(api): [#187] add tests for new 'tag' context (Jose Celano)

Pull request description:

  A new API context was created, `tag`, but the code is in the ActixWeb handler. [We were migrating that code to services](#157).

Top commit has no ACKs.

Tree-SHA512: 8cf608d2d3b5517f971e836feddc4bfc29391adde2f68221ee5000e5fbea532c49cb5d33f31c99f2e95c650b25bf16496df7c8beb591a735cb6647af1ba47960

The workflow "Development checks" is not failing if E2E tests fail. This
fixes that problem.

b4c43da fix: [#189] make 'Development checks' workflow fail if E2E tests fail (Jose Celano)

Pull request description:

  The workflow "Development checks" is not failing if E2E tests fail. This fixes that problem.

Top commit has no ACKs.

Tree-SHA512: ab4b21a495f7f25c0a3172ed08fe31ccf398598053a1384bc4d707a28c6c99066113bd2d6e9868ca162cefd67944674767460e8afae3bb7a5017a6402d623cf5

The SQL query:

```
SELECT
  COUNT(*) as count
FROM
  (
    SELECT
      tt.torrent_id,
      tp.username AS uploader,
      tt.info_hash,
      ti.title,
      ti.description,
      tt.category_id,
      DATE_FORMAT(tt.date_uploaded, '%Y-%m-%d %H:%i:%s') AS date_uploaded,
      tt.size AS file_size,
      CAST(COALESCE(sum(ts.seeders), 0) as signed) as seeders,
      CAST(COALESCE(sum(ts.leechers), 0) as signed) as leechers
    FROM
      torrust_torrents tt
      INNER JOIN torrust_user_profiles tp ON tt.uploader_id = tp.user_id
      INNER JOIN torrust_torrent_info ti ON tt.torrent_id = ti.torrent_id
      LEFT JOIN torrust_torrent_tracker_stats ts ON tt.torrent_id = ts.torrent_id
    WHERE
      title LIKE ?
    GROUP BY
      tt.torrent_id
  ) AS count_table
```

should not use the `DATE_FORMAT` function in SQLite.

6023b96 fix: [#190] SQL error in SQLite (Jose Celano)

Pull request description:

  The SQL query:

  ```sql
  SELECT
    COUNT(*) as count
  FROM
    (
      SELECT
        tt.torrent_id,
        tp.username AS uploader,
        tt.info_hash,
        ti.title,
        ti.description,
        tt.category_id,
        DATE_FORMAT(tt.date_uploaded, '%Y-%m-%d %H:%i:%s') AS date_uploaded,
        tt.size AS file_size,
        CAST(COALESCE(sum(ts.seeders), 0) as signed) as seeders,
        CAST(COALESCE(sum(ts.leechers), 0) as signed) as leechers
      FROM
        torrust_torrents tt
        INNER JOIN torrust_user_profiles tp ON tt.uploader_id = tp.user_id
        INNER JOIN torrust_torrent_info ti ON tt.torrent_id = ti.torrent_id
        LEFT JOIN torrust_torrent_tracker_stats ts ON tt.torrent_id = ts.torrent_id
      WHERE
        title LIKE ?
      GROUP BY
        tt.torrent_id
    ) AS count_table
  ```

  should not use the `DATE_FORMAT` function in SQLite.

Top commit has no ACKs.

Tree-SHA512: 44de35f013c0209bd51ce241fbf53bbf4745ecf37883c1af73bd2a80ae484074a93d8e5ea9d480da8ee8699828bf232dfdc2cd1cfe1649b49c8e0ab8667d5563

With the new Axum implementation for the API the browser does not make
request to the API becuase of the Cross-Origin Resource Sharing (CORS)
policy. By default there is no header `Access-Control-Allow-Origin` and
it does not allow the request.

You can be permissive by adding a layer to the router:

```
Router::new().nest("/v1", api_routes).layer(CorsLayer::permissive())
```

For the time being you need to change that line manually when you want
to setup a dev env with the banckend and the frontend using different
ports.

d3b5b15 refactor(api): [#183] Axum API, user context, ban user (Jose Celano)
9564dec refactor(api): [#183] Axum API, user context, renew JWT (Jose Celano)
b15616c refactor(api): [#183] Axum API, user context, verify JWT (Jose Celano)
3f639b3 refactor(api): [#183] Axum API, user context, login (Jose Celano)
a341e38 refactor(api): [#183] Axum API, user context, email verification (Jose Celano)
91522f4 feat: add cargo dependency tower-http (Jose Celano)
79682a5 refactor(api): [#183] Axum API, user context, registration (Jose Celano)

Pull request description:

  API migration to Axum for `user` context.

Top commit has no ACKs.

Tree-SHA512: efd396039246739428c9b80ff942b8672bcf115a5d4dcac1ef18fb960de1d2dfd8d86bf1d490b6d6b8294f0fd9d3f92b9f89814c781d632a8533074cccca08b0

b4a7ea6 refactor(api): [#179] Axum API, category context, delete category (Jose Celano)
f63bf05 refactor(api): [#179] Axum API, category context, add category (Jose Celano)
bb6d9bf refactor(api): [#179] Axum API, category context, get all categories (Jose Celano)
6f9c1a2 refactor: API category context tetests (Jose Celano)

Pull request description:

  API migration to Axum for `category` context.

Top commit has no ACKs.

Tree-SHA512: 01a983f5e2f8c1a547aea5145cb7133b572dbf4569cb84db1b4272b03cdcd283d44ce4b4a1c1a3618c145242bc0e019bb3c02805e4b1cbf6ee558c9be80462cf

878bb7b refactor(api): [#198] Axum API, root endpoints (Jose Celano)

Pull request description:

  API migration to Axum for root endpoints.

Top commit has no ACKs.

Tree-SHA512: 66db7642c3bb9c66a757369e25005d0a31fe1086509b0072c2063fbe002ae5ec47f94544b4a17cbfbea1cd751d2960551e2f83dabf1a752545e8417b7b912a0a

b53ce8d refactor(api): [#198] Axum API, tag context (Jose Celano)

Pull request description:

  API migration to Axum for `tag` context.

Top commit has no ACKs.

Tree-SHA512: 8d14fa225fa87d54d3aba217a942510113864aff5e98f08e391f50aba304ff79ff65482fb2751e62f2e4bb9153367512dc859948bb2467b03e3999ba0e366fef

dc469c4 refactor(api): [#181] Axum API, settings contex (Jose Celano)

Pull request description:

  API migration to Axum for `settings` context.

Top commit has no ACKs.

Tree-SHA512: 0f6522a66b49278d92502363e787fd2da5431bb4bde1541ddb572d033050e52e0e594ba10c9e600afc3bf38c42bca07a20b41a0bf4be1d5bf797018b3b48b9f2

We are migrating the API to Axum. We need the `multipart` feature to
handle the upload torrent file POST.

24394ea refactor(api): [#182] Axum API, torrent context, delete torrent info (Jose Celano)
ca257ff refactor(api): [#182] Axum API, torrent context, update torrent info (Jose Celano)
4bed98a refactor(api): [#182] Axum API, torrent context, get torrent info (Jose Celano)
b998a16 refactor(api): [#182] Axum API, torrent context, search for torrents (Jose Celano)
ed533b7 refactor(api): [#182] Axum API, torrent context, download torrent file (Jose Celano)
538ebcc refactor(api): [#182] Axum API, torrent context, upload torrent file (Jose Celano)
d7f1e34 feat(api): add multipart feature for Axum package (Jose Celano)

Pull request description:

  API migration to Axum for `torrent` context.

  Torrent files:

  - [x] Upload torrent file
  - [x] Download torrent file

  Indexed torrents:

  - [x] Search for torrents
  - [x] Get torrent info
  - [x] Update torrent
  - [x] Delete torrent

Top commit has no ACKs.

Tree-SHA512: 7f943127dc73d534a49f4091007ab7fef32f089b6bdd852b3fe68bd7a579e83be1d578db4ccad16706884045b37fa924f5f73e2578fc6d0cd3a1e9156d3360cf

0af2cb7 refactor(api): [#180] Axum API, proxy context (Jose Celano)

Pull request description:

  API migration to Axum for `proxy` context.

Top commit has no ACKs.

Tree-SHA512: 7519335e6b49f098b2df913ba32574d86c99953ec66892d6227d7d2f9b695801c08d3a36bdd9c0239e9bcf6d35af2fbaaa8348d1531ed9a8a15e6e1acbd83580

Response after deleting a tag should be:

```
{
  data: 1
}
```

not:

```
{
  data: "1"
}
```

where 1 (`i64`) is the tag ID.

The application allows adding empty categories. The test cannot be
executed in a shared env because it would fail the second tie is
executed becuase the category already exists.

If the handlers return an error Axum does not automatically return an
error HTTP code. See
https://docs.rs/axum/latest/axum/error_handling/index.html. You have to
convert the error into an error response.

This function could be used by many other handlers.

We are going to remove the ActixWeb implementation after enabling the
new Axum implementaion. WE are moving generic things in ActixWeb
implementations that are not going to be removed.

It's been used also in Axum implementation and ActixWeb implementation
will be removed.

It depends on the web framework (request).

f0017ae refactor(api): move auth logic to web api (Jose Celano)
ff8816f refactor(api): rename structs (Jose Celano)
d8b2104 refactor(api): move Create struct (Jose Celano)
9591239 refector(api): move API_VERSION const out of ActixWeb implementation (Jose Celano)
a6881e3 refactor: move funtion get_optional_logged_in_user (Jose Celano)
b73d864 fix(api): Axum API, error should return a 500 status code (Jose Celano)
b4744e7 test(api): fix test for empty categories (Jose Celano)
34db879 fix(api): Axum API, fix delete tag response (Jose Celano)

Pull request description:

  Before enabling Auxm API, there are some minor changes and fixes to do.

Top commit has no ACKs.

Tree-SHA512: 5f02553f58aa9cebe98fe500577b6bfe235bafa40b04835a5a2a8527fd519ddfc1004a1272548e96ae2e611589de05dac39e3533c587312b61aea4fe46d2dcce

6fc6872 refactor(api): [#197] make Axum implementation the default one (Jose Celano)

Pull request description:

  This makes the Axum implementation the default one for the API.

Top commit has no ACKs.

Tree-SHA512: 353db42a19e98eaed3ab417a55865240d070ef834d89501d053cd01ba39cb4c5b3b35b5ac519136730fe49862d267fc11ace9414b7b6bf637bb1e6e80c6e6760

We've removed the ActixWeb implementation for the API. We can use the
enum for implementations for versioning the API. Currently there is only
one version `v1` but i'ts ready to add the verion `v2`.

717cdaa refactor(api): [#208] use API impementation enum for API versioning (Jose Celano)
44c799e refator(api): [#208] remove ActixWeb implementation (Jose Celano)

Pull request description:

  Remove ActixWeb implementation.

Top commit has no ACKs.

Tree-SHA512: 62e9724aabaf06c7ef1d2be3f8fe9e8a45ffe667ea96aa52018829231fc5ae80c7957e946040db43eccefeb544b685466e86c665d33ade50bef50727440ad116

Running the backend with:

```
TORRUST_IDX_BACK_CORS_PERMISSIVE=true cargo run
```

will make the CORS policy to be permissive, which means you can use a
different port for the API and serving the frontend app. It's intented
for development purposes.

f998d9d feat: add env var to set permissive CORS policy (Jose Celano)

Pull request description:

  Running the backend with:

  ```
  TORRUST_IDX_BACK_CORS_PERMISSIVE=true cargo run
  ```

  will make the CORS policy to be permissive, which means you can use a different port for the API and serving the frontend app. It's intented for development purposes.

Top commit has no ACKs.

Tree-SHA512: eda45426fb6e6aeceb7213066354a3d9b83de6a3d3e757788e5500c84c2900f6d15f16c95c1b82ae763c487847827c9592859e206a41feb37eec4755a9ea8ff9

b4ea3d5 fix: [#216] allow updating torrent category after upload (Jose Celano)

Pull request description:

  Allow updating torrent category after upload.

Top commit has no ACKs.

Tree-SHA512: c97b8cc2c8d2c1fb25db58d5eda456bf893d48350c9b909f1672d69555cc2aea9404fa905d2b85ab1e1f0b47d9ecf8d4e9650876b1c44e5fc3d8003c1f7bdd57

Because:

- They are hard to maintain because of the table's dependencies.
- They are duplicated in E2E tests. And it's easier to set the state you want to test with E2E tests.

TODO: runt the E2E test using MySQL to ensure queries are OK. Currently, E2E tests are only executed with SQLite.

When you upgrade from v1.0.0 to v2.0.0 you can run an upgrader which
will truncate all the tables in the target database. There were some
missing tables in the list. Probably, there wre tables added after
creting the upgrader command.

… function

986d2f8 fix: [#194] add missing tables to truncate when reseting the DB (Jose Celano)
7a06fe8 test: [#194] remove database tests (Jose Celano)

Pull request description:

  Fix the function `delete_all_database_rows` to delete all tables.

  Besides, remove database tests because:

  - They are hard to maintain because of the table's dependencies.
  - They are duplicated in E2E tests. And it's easier to set the state you want to test with E2E tests.

  TODO: runt the E2E test using MySQL to ensure queries are OK. Currently, E2E tests are only executed with SQLite.

Top commit has no ACKs.

Tree-SHA512: 102b366c5c3be399a4f9801ea3a888c2c17219f0c9f72313441a677458ac18249872798e339cc0781c784610534de711c102aa10416d3cdb60bf71aefb668fc2

Without restarting the application. This feature was using the `config.toml` file. That approach is not good for theses reasons:

- If you use env vars to inject the settings, there is no `config.toml` file.
- In dockerized (clouds) envs it's harder to mount a file than injecting env vars. Sometimes it's only allowed to mount a single file.

f85e153 feat!: [#144] don't allow to update settings (Jose Celano)

Pull request description:

  Without restarting the application. This feature was using the `config.toml` file. That approach is not good for theses reasons:

  - If you use env vars to inject the settings, there is no `config.toml` file.
  - In dockerized (clouds) envs it's harder to mount a file than injecting env vars. Sometimes it's only allowed to mount a single file.

Top commit has no ACKs.

Tree-SHA512: 6d20384acb520d314cf5eb9a0f114f5209a72d60fd9804bccc8a914a7f9beaaff040fe15e556c2e61f99686406b401d52175fe280ccf4451c671ee8e3e31440e

The endpoint to get the torrent info details returns a 404 HTTP status
code instead of a 400, when the provided infohash does not exist in the
database.

The endpoint to download a torrent file is also changed.

21ee689 feat!: [#215] return 404 when torrent is not found (Jose Celano)

Pull request description:

  The [endpoint to get the torrent info details](https://github.com/torrust/torrust-index-backend/blob/develop/src/web/api/v1/contexts/torrent/handlers.rs#L112-L128) returns a `404` HTTP status code instead of a `400` when the provided infohash does not exist in the database.

  The [endpoint to download the torrent file](https://github.com/torrust/torrust-index-backend/blob/develop/src/web/api/v1/contexts/torrent/handlers.rs#L66-L86) is also changed.

Top commit has no ACKs.

Tree-SHA512: c3e39e9e7742691f98d71f3485632ca0fcf481114c90dc9173e65623bdf38f197714f91a0d476ae2ddfbeb8f5ee5ff5cd007f62c68007066db8ce34f2b8813a1

The JSON response can now contain a `null` value for the `category`:

```json
{
    "data": {
        "torrent_id": 1,
        "uploader": "josecelano",
        "info_hash": "E8564469C258B1373BC2D5749FB83B1BF83D68A0",
        "title": "Ubuntu",
        "description": null,
        "category": null,
        "upload_date": "2023-06-27 11:35:09",
        "file_size": 1261707713,
        "seeders": 0,
        "leechers": 0,
        "files": [
            {
                "path": [
                    "NNN.url"
                ],
                "length": 114,
                "md5sum": null
            },
            {
                "path": [
                    "XXX.url"
                ],
                "length": 121,
                "md5sum": null
            },
            {
                "path": [
                    "XXX.avi"
                ],
                "length": 1261707478,
                "md5sum": null
            }
        ],
        "trackers": [
            "udp://tracker:6969",
        ],
        "magnet_link": "magnet:?xt=urn:btih:E8564469C258B1373BC2D5749FB83B1BF83D68A0&dn=Ubuntu&tr=udp%3A%2F%2Ftracker%3A6969e",
        "tags": []
    }
}
```

21a1f16 feat!: [#97] make torrent category optional (Jose Celano)

Pull request description:

  The JSON response can now contain a `null` value for the `category`:

  ```json
  {
      "data": {
          "torrent_id": 1,
          "uploader": "josecelano",
          "info_hash": "E8564469C258B1373BC2D5749FB83B1BF83D68A0",
          "title": "Ubuntu",
          "description": null,
          "category": null,
          "upload_date": "2023-06-27 11:35:09",
          "file_size": 1261707713,
          "seeders": 0,
          "leechers": 0,
          "files": [
              {
                  "path": [
                      "NNN.url"
                  ],
                  "length": 114,
                  "md5sum": null
              },
              {
                  "path": [
                      "XXX.url"
                  ],
                  "length": 121,
                  "md5sum": null
              },
              {
                  "path": [
                      "XXX.avi"
                  ],
                  "length": 1261707478,
                  "md5sum": null
              }
          ],
          "trackers": [
              "udp://tracker:6969",
          ],
          "magnet_link": "magnet:?xt=urn:btih:E8564469C258B1373BC2D5749FB83B1BF83D68A0&dn=Ubuntu&tr=udp%3A%2F%2Ftracker%3A6969e",
          "tags": []
      }
  }
  ```

Top commit has no ACKs.

Tree-SHA512: 1b0ad7e616de6af544aa37b7c3357e6ca351e8d2d3999ac83abd9f61e1b686810979fa23e117a2432e2755e00c284b8ac939c949293a5815c08c76fc149ca459