Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Version 3.0.0-alpha.12 #1009

Merged
merged 532 commits into from
Aug 13, 2024
Merged

Release Version 3.0.0-alpha.12 #1009

merged 532 commits into from
Aug 13, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Aug 12, 2024 •
edited
Loading

Release Version 3.0.0-alpha.12 following the release process.

josecelano and others added 30 commits April 19, 2024 09:38
@josecelano
Merge #805: Update dependencies
9a1ce0e 
87c9834 chore(deps): update dependencies (Jose Celano)

Pull request description:

  ```ouput
  Updating crates.io index
  Updating chrono v0.4.37 -> v0.4.38
  Updating hyper v1.2.0 -> v1.3.1
  Updating proc-macro2 v1.0.80 -> v1.0.81
  Updating serde v1.0.197 -> v1.0.198
  Updating serde_derive v1.0.197 -> v1.0.198
  Updating serde_json v1.0.115 -> v1.0.116
  Updating syn v2.0.59 -> v2.0.60
  Updating toml_edit v0.22.9 -> v0.22.11
  ```

ACKs for top commit:
  josecelano:
    ACK 87c9834

Tree-SHA512: 23b9aabdd9f64eaa8620a3e74dab600982fa23330601e868345185976bbc6e9826b659940e7d84b3cc4d28f1dcec9b9dedf9d163e57bbbd1ac6c95ed6083413e
@hungfnt
chore:[#674] Tracker Checker: Ouput in JSON
b301596
@hungfnt
format fix
7de4fbc
@hungfnt
remove unused dependencies
b27f002
@josecelano
Merge #810: chore:[#674] Tracker Checker: Ouput in JSON
92349d3 
b27f002 remove unused dependencies (ngthhu)
7de4fbc format fix (ngthhu)
b301596 chore:[#674] Tracker Checker: Ouput in JSON (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK b27f002

Tree-SHA512: 571125c6204f98e49d7003ab16549dc98f258f4c183e029dcddb53f5af5a72c8fa8cb564d2afef075ea5ee35edad72a593467b551c43dca18430d79f229b0eb6
@hungfnt
refactor: [#681] udp return errors instead of panicking
effca56
@josecelano
Merge #814: Refactor UdpClient to return errors instead of panicking
90c7780 
effca56 refactor: [#681] udp return errors instead of panicking (ngthhu)

Pull request description:

  I replaced panics with error handling using `anyhow::Result<T>`, which is equivalent to `std::result::Result<T, anyhow::Error>`. Although I can run `cargo run` without errors, I'm not certain if there are any hidden bugs.

ACKs for top commit:
  josecelano:
    ACK effca56

Tree-SHA512: 30653458d1f2b3155dbdddd0f5197cee6746819122db45d58c0aaa4a0b9cae0fccee76b769afb22b57749c2140d042580125ad2689fafa0b65ec6847866f659b
@hungfnt
refactor: [#680] http return errors instead of panicking
895efe9
@josecelano
Merge #826: refactor: [#680] http return errors instead of panicking
f64e8fb 
895efe9 refactor: [#680] http return errors instead of panicking (ngthhu)

Pull request description:

  Refactor: HTTP tracker client returns errors instead of panicking.

ACKs for top commit:
  josecelano:
    ACK 895efe9

Tree-SHA512: 96a96a45ba71fabcf1857aeaa013cb333eee20620b749d5fa4d241fb9ccc7fe46161dca08de5c42881418cfe7676e18a5171a20755a6e3d1e1fe542957820b68
@josecelano
chore(deps): update dependencies
7551857
@josecelano
Merge #832: Update dependencies
2719d5e 
7551857 chore(deps): update dependencies (Jose Celano)

Pull request description:

  ```output
      Updating crates.io index
       Locking 63 packages to latest compatible versions
      Updating anstream v0.6.13 -> v0.6.14
      Updating anstyle v1.0.6 -> v1.0.7
      Updating anstyle-parse v0.2.3 -> v0.2.4
      Updating anstyle-query v1.0.2 -> v1.0.3
      Updating anstyle-wincon v3.0.2 -> v3.0.3
        Adding aquatic_peer_id v0.9.0
      Updating aquatic_udp_protocol v0.8.0 -> v0.9.0
      Updating async-compression v0.4.8 -> v0.4.9
      Updating async-task v4.7.0 -> v4.7.1
      Updating autocfg v1.2.0 -> v1.3.0
      Updating base64 v0.22.0 -> v0.22.1
      Updating blocking v1.5.1 -> v1.6.0
      Updating borsh v1.4.0 -> v1.5.0
      Updating borsh-derive v1.4.0 -> v1.5.0
      Updating brotli v4.0.0 -> v5.0.0 (latest: v6.0.0)
      Updating brotli-decompressor v3.0.0 -> v4.0.0
        Adding castaway v0.2.2
      Updating cc v1.0.94 -> v1.0.96
      Updating colorchoice v1.0.0 -> v1.0.1
        Adding compact_str v0.7.1
      Updating concurrent-queue v2.4.0 -> v2.5.0
        Adding env_logger v0.8.4 (latest: v0.11.3)
      Updating event-listener-strategy v0.5.1 -> v0.5.2
      Updating fastrand v2.0.2 -> v2.1.0
      Updating flate2 v1.0.28 -> v1.0.30
      Updating hashbrown v0.14.3 -> v0.14.5
        Adding is_terminal_polyfill v1.70.0
      Updating jobserver v0.1.30 -> v0.1.31
      Updating libc v0.2.153 -> v0.2.154
      Updating lock_api v0.4.11 -> v0.4.12
      Updating num-traits v0.2.18 -> v0.2.19
      Updating parking_lot v0.12.1 -> v0.12.2
      Updating parking_lot_core v0.9.9 -> v0.9.10
      Updating pest v2.7.9 -> v2.7.10
      Updating pest_derive v2.7.9 -> v2.7.10
      Updating pest_generator v2.7.9 -> v2.7.10
      Updating pest_meta v2.7.9 -> v2.7.10
      Updating polling v3.6.0 -> v3.7.0
        Adding quickcheck v1.0.3
      Updating redox_syscall v0.4.1 -> v0.5.1
      Updating relative-path v1.9.2 -> v1.9.3
      Updating reqwest v0.12.3 -> v0.12.4
      Updating ringbuf v0.3.3 -> v0.4.0
      Updating rustix v0.38.32 -> v0.38.34
      Updating rustls v0.21.10 -> v0.21.12 (latest: v0.23.5)
      Updating rustls-pki-types v1.4.1 -> v1.5.0
      Updating security-framework v2.10.0 -> v2.11.0
      Updating security-framework-sys v2.10.0 -> v2.11.0
      Updating serde v1.0.198 -> v1.0.200
      Updating serde_derive v1.0.198 -> v1.0.200
      Updating serde_with v3.7.0 -> v3.8.1
      Updating serde_with_macros v3.7.0 -> v3.8.1
      Updating signal-hook-registry v1.4.1 -> v1.4.2
      Updating socket2 v0.5.6 -> v0.5.7
      Updating thiserror v1.0.58 -> v1.0.59
      Updating thiserror-impl v1.0.58 -> v1.0.59
      Updating tokio-util v0.7.10 -> v0.7.11
      Updating toml_edit v0.22.11 -> v0.22.12
      Updating value-bag v1.8.1 -> v1.9.0
      Updating winapi-util v0.1.6 -> v0.1.8
      Updating winnow v0.6.6 -> v0.6.8
      Updating zerocopy v0.7.32 -> v0.7.33
      Updating zerocopy-derive v0.7.32 -> v0.7.33
  ```

  I had to revert some crates due to breaking changes:

  - ringbuf
  - aquatic_udp_protocol

ACKs for top commit:
  josecelano:
    ACK 7551857

Tree-SHA512: 63089013a1ed9c10c811486b8e4e849b86978bff7b45a8251b4a94a84732fa656bed61c6db351b1e4da4ebd4799a645ec2064388d182df781fae373aa21d3534
@josecelano
chore(deps): bump aquatic_udp_protocol from 0.8.0 to 0.9.0
801d913
@josecelano
Merge #837: Bump aquatic_udp_protocol from 0.8.0 to 0.9.0
25ecdce 
801d913 chore(deps): bump aquatic_udp_protocol from 0.8.0 to 0.9.0 (Jose Celano)

Pull request description:

  Bump `aquatic_udp_protocol` from `0.8.0` to `0.9.0`.
  There are breaking changes.

ACKs for top commit:
  josecelano:
    ACK 801d913

Tree-SHA512: 5ae9daacf52176850f24cb2421be8795fd8abe8cb7503a7a0f6be3c3ed081a8f384230d3ce5a3a0122508bfa3d8c5ff94c4763a67d99b3191fefdd0bc8b4c278
@josecelano
chore(deps): bump ringbuf from 0.3.3 to 0.4.0
be51d2f
@josecelano
Merge #839: Bump ringbuf from 0.3.3 to 0.4.0
36a0b96 
be51d2f chore(deps): bump ringbuf from 0.3.3 to 0.4.0 (Jose Celano)

Pull request description:

  Bump `ringbuf` from `0.3.3` to `0.4.0`.

ACKs for top commit:
  josecelano:
    ACK be51d2f

Tree-SHA512: aa12d494e2035cd6fd2dcf2b863b84ba675764faca75130e17dfd076d81e9eba73185ef524e43ea7aa3acbaa17115eb85ffe01013c565e7a7536bf9d8e0653b3
@josecelano
chore(deps): update dependencies
62d4a20 
```output
cargo update
    Updating crates.io index
     Locking 14 packages to latest compatible versions
    Updating anyhow v1.0.82 -> v1.0.83
    Updating cc v1.0.96 -> v1.0.97
    Updating getrandom v0.2.14 -> v0.2.15
    Updating num-bigint v0.4.4 -> v0.4.5
    Updating proc-macro2 v1.0.81 -> v1.0.82
    Updating rustls-pki-types v1.5.0 -> v1.6.0
    Updating rustversion v1.0.15 -> v1.0.16
    Updating ryu v1.0.17 -> v1.0.18
    Updating semver v1.0.22 -> v1.0.23
    Updating syn v2.0.60 -> v2.0.61
    Updating thiserror v1.0.59 -> v1.0.60
    Updating thiserror-impl v1.0.59 -> v1.0.60
    Updating zerocopy v0.7.33 -> v0.7.34
    Updating zerocopy-derive v0.7.33 -> v0.7.34
```
@josecelano
Merge #840: Update dependencies
5348669 
62d4a20 chore(deps): update dependencies (Jose Celano)

Pull request description:

  ```output
  cargo update
      Updating crates.io index
       Locking 14 packages to latest compatible versions
      Updating anyhow v1.0.82 -> v1.0.83
      Updating cc v1.0.96 -> v1.0.97
      Updating getrandom v0.2.14 -> v0.2.15
      Updating num-bigint v0.4.4 -> v0.4.5
      Updating proc-macro2 v1.0.81 -> v1.0.82
      Updating rustls-pki-types v1.5.0 -> v1.6.0
      Updating rustversion v1.0.15 -> v1.0.16
      Updating ryu v1.0.17 -> v1.0.18
      Updating semver v1.0.22 -> v1.0.23
      Updating syn v2.0.60 -> v2.0.61
      Updating thiserror v1.0.59 -> v1.0.60
      Updating thiserror-impl v1.0.59 -> v1.0.60
      Updating zerocopy v0.7.33 -> v0.7.34
      Updating zerocopy-derive v0.7.33 -> v0.7.34
  ```

ACKs for top commit:
  josecelano:
    ACK 62d4a20

Tree-SHA512: 3cd650de6dffdf1fc809184947c2e3b9bba242c11ad0a713fc0159694544f4da8baa14cfd1f82d9c75f403abe31d5cebcb526d187c972ce0667813e3d7db39d1
@josecelano
feat: log aborted UDP requests
e3143f7 
This will add a warning to the lofs when a UDP request is aborted.
@josecelano
Merge #841: feat: log aborted UDP requests
690d1d2 
e3143f7 feat: log aborted UDP requests (Jose Celano)

Pull request description:

  This will add a warning to the logs when a UDP request is aborted.

ACKs for top commit:
  josecelano:
    ACK e3143f7

Tree-SHA512: db44e3358e3ac45d36c0f88c420bfdd3b0412d2ee4a4c7d564a47aba5398979b4d1765836ae740855943e4559c1f68520d8c5256690839c864559f4ef3d46a37
@josecelano
docs: udpate installation docs
3dee03e
@josecelano
Merge #843: Update installation docs
a1408ad 
3dee03e docs: udpate installation docs (Jose Celano)

Pull request description:

  Update installation docs.

ACKs for top commit:
  josecelano:
    ACK 3dee03e

Tree-SHA512: 2bce1719680d8aaceac3c1b72929fd67d3a1b664af3dbb324c7afcc98581768f64e8415e2735366b49a6ababf77df37f12f8dbb074953ce3c5a18be654fc476d
@josecelano
chore(deps): bump rustc-demangle v0.1.23 -> v0.1.24
cddc4de
@josecelano
Merge #844: chore(deps): bump rustc-demangle from v0.1.23 to `v0.…
a0a51c8 
…1.24`

cddc4de chore(deps): bump rustc-demangle v0.1.23 -> v0.1.24 (Jose Celano)

Pull request description:

  ```output
  cargo update
      Updating crates.io index
       Locking 1 package to latest compatible version
      Updating rustc-demangle v0.1.23 -> v0.1.24
  ```

Top commit has no ACKs.

Tree-SHA512: 25d2d2fc8219df4d03633f93a1806ea7fe596fc31e374fdc76307cd38931e282eb853c88ea4b0aeb91b0ba3614c51c57d02fedc983a7c608501967030bec67a3
@josecelano
docs: fix profiling docs
6f02aeb 
- Remove unnecessary file
- Fix filename typo
@josecelano
Merge #847: docs: fix profiling docs
218fbbe 
6f02aeb docs: fix profiling docs (Jose Celano)

Pull request description:

  - Remove unnecessary file
  - Fix filename typo

ACKs for top commit:
  josecelano:
    ACK 6f02aeb

Tree-SHA512: e2718c84474debd08a7c05f31d99be253454d7f504e6a6327e2c607ca9691abafac44cbb3d202f905c6d600f6676fa6dc0dfa703cf1fc38bccd02162ceca7bf0
@da2ce7 @josecelano
dev: fix udp ring-buffer not looping
9e01f7f 
My previous version would be limited to a single thread, as `push_overwrite` would keep on returning the last element when the ring-buffer was full.

Now the ring-buffer is pre-filled and is looped over with a mutating iterator.

New handles are progressively swapped-in when the old entries are finished.

Note: I think that this implementation can be replaced with a standard vector with the same effect.
@josecelano
Merge #846: dev: fix udp ring-buffer not looping
31ab3a9 
9e01f7f dev: fix udp ring-buffer not looping (Cameron Garnham)

Pull request description:

  @da2ce7's previous version would be limited to a single thread, as `push_overwrite` would keep on returning the last element when the ring-buffer was full.

  Now, the ring-buffer is pre-filled and is looped over with a mutating iterator.

  New handles are progressively swapped-in when the old entries are finished.

  Note: I think that this implementation can be replaced with a standard vector with the same effect.

Top commit has no ACKs.

Tree-SHA512: 362ea9148c7a7c6c990b881fe34087f4f61fdd80aa6aecfe3d11f3da3d0440fa6db38e97bb93fc8e57ed55cc05d229260bf353b5d06c7541b88a710ddbe5bba4
@josecelano
chore(deps): add dependency figment
7da52b1 
It will replace the custom code for configuration inyection.
@josecelano
test: remove broken example in rustdoc
f0e0721
@josecelano
chore(deps): enable figment features: env, toml, test
157807c
@josecelano
Merge #992: Config overhaul: make some fields mandatory
1ca90ad 
90ef14d feat!: [#938] add mandatory config options (Jose Celano)

Pull request description:

  Some configuration options are mandatory. The tracker will panic if the user doesn't provide an explicit value for them from one of the configuration sources: TOML or ENV VARS.

  The mandatory options are:

  ```toml
  [metadata]
  schema_version = "2.0.0"

  [logging]
  threshold = "info"

  [core]
  private = false
  listed = false
  ```

ACKs for top commit:
  josecelano:
    ACK 90ef14d

Tree-SHA512: 428d599f81842e97335e771a7aa99f88b5f885b7f0026c1883a21b0cbddb4afca9e255aa7cfba637f3e9b3ddeb1c5314a832bb072df7ca21ff73be068d4814d8
@josecelano
chore(deps): update dependencies
7c62645 
```output
cargo update
    Updating crates.io index
     Locking 35 packages to latest compatible versions
      Adding aws-lc-rs v1.8.1
      Adding aws-lc-sys v0.20.1
    Updating axum-server v0.6.0 -> v0.7.1
    Updating bytemuck v1.16.1 -> v1.16.3
    Updating bytes v1.6.1 -> v1.7.1
    Updating cc v1.1.6 -> v1.1.7
    Updating clap v4.5.11 -> v4.5.13
    Updating clap_builder v4.5.11 -> v4.5.13
    Updating clap_derive v4.5.11 -> v4.5.13
      Adding dunce v1.0.5
    Updating flate2 v1.0.30 -> v1.0.31
      Adding fs_extra v1.3.0
      Adding home v0.5.9
    Updating indexmap v2.2.6 -> v2.3.0
    Updating lru v0.12.3 -> v0.12.4
      Adding mirai-annotations v1.12.0
      Adding paste v1.0.15
    Updating ppv-lite86 v0.2.17 -> v0.2.20
      Adding prettyplease v0.2.20
    Updating regex v1.10.5 -> v1.10.6
    Updating rstest v0.21.0 -> v0.22.0
    Updating rstest_macros v0.21.0 -> v0.22.0
    Removing rustls v0.21.12
    Updating rustls-pemfile v2.1.2 -> v2.1.3
    Removing rustls-webpki v0.101.7
    Removing sct v0.7.1
    Updating serde_json v1.0.121 -> v1.0.122
    Updating tempfile v3.10.1 -> v3.11.0
    Removing tokio-rustls v0.24.1
    Updating toml v0.8.16 -> v0.8.19
    Updating toml_datetime v0.6.7 -> v0.6.8
    Updating toml_edit v0.22.17 -> v0.22.20
      Adding which v4.4.2 (latest: v6.0.2)
    Updating winapi-util v0.1.8 -> v0.1.9
      Adding windows-sys v0.59.0
    Updating winnow v0.6.16 -> v0.6.18
      Adding zeroize_derive v1.4.2
    Updating zstd-safe v7.2.0 -> v7.2.1
    Updating zstd-sys v2.0.12+zstd.1.5.6 -> v2.0.13+zstd.1.5.6
```
@josecelano
Merge #995: Update dependencies
e40e75d 
7c62645 chore(deps): update dependencies (Jose Celano)

Pull request description:

  ```output
  cargo update
      Updating crates.io index
       Locking 35 packages to latest compatible versions
        Adding aws-lc-rs v1.8.1
        Adding aws-lc-sys v0.20.1
      Updating axum-server v0.6.0 -> v0.7.1
      Updating bytemuck v1.16.1 -> v1.16.3
      Updating bytes v1.6.1 -> v1.7.1
      Updating cc v1.1.6 -> v1.1.7
      Updating clap v4.5.11 -> v4.5.13
      Updating clap_builder v4.5.11 -> v4.5.13
      Updating clap_derive v4.5.11 -> v4.5.13
        Adding dunce v1.0.5
      Updating flate2 v1.0.30 -> v1.0.31
        Adding fs_extra v1.3.0
        Adding home v0.5.9
      Updating indexmap v2.2.6 -> v2.3.0
      Updating lru v0.12.3 -> v0.12.4
        Adding mirai-annotations v1.12.0
        Adding paste v1.0.15
      Updating ppv-lite86 v0.2.17 -> v0.2.20
        Adding prettyplease v0.2.20
      Updating regex v1.10.5 -> v1.10.6
      Updating rstest v0.21.0 -> v0.22.0
      Updating rstest_macros v0.21.0 -> v0.22.0
      Removing rustls v0.21.12
      Updating rustls-pemfile v2.1.2 -> v2.1.3
      Removing rustls-webpki v0.101.7
      Removing sct v0.7.1
      Updating serde_json v1.0.121 -> v1.0.122
      Updating tempfile v3.10.1 -> v3.11.0
      Removing tokio-rustls v0.24.1
      Updating toml v0.8.16 -> v0.8.19
      Updating toml_datetime v0.6.7 -> v0.6.8
      Updating toml_edit v0.22.17 -> v0.22.20
        Adding which v4.4.2 (latest: v6.0.2)
      Updating winapi-util v0.1.8 -> v0.1.9
        Adding windows-sys v0.59.0
      Updating winnow v0.6.16 -> v0.6.18
        Adding zeroize_derive v1.4.2
      Updating zstd-safe v7.2.0 -> v7.2.1
      Updating zstd-sys v2.0.12+zstd.1.5.6 -> v2.0.13+zstd.1.5.6
  ```

ACKs for top commit:
  josecelano:
    ACK 7c62645

Tree-SHA512: 23d783ba4f9af3c8de6b6d0a311dd0fa2f292419d8bce00ad503521e4fb39cf8fe3fabc6339c573a16bb40592efef96cf0f1ba942f01f75391ad892253880fd0
@josecelano
docs: update roadmap in README
5939b9a 
Permanent keys have been already implemented.
@josecelano
Merge #996: docs: update roadmap in README
0a04dde 
5939b9a docs: update roadmap in README (Jose Celano)

Pull request description:

  Remove the "Permanent keys" feature from the roadmap. They have already been implemented.

ACKs for top commit:
  josecelano:
    ACK 5939b9a

Tree-SHA512: 7cf0f7b088b729f9b1648f2b23e6db9fa385b9bb0c7582a86f3199c6140d2796d0d490afe5d74866358190aaed6af07f190d4153d3e20147cc82b156f7b2d236
@josecelano
feat: disable TimeoutAcceptor when TSL is enabled
222fa42 
The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput
for making a request after openning a connection.

It does not work when TSL is enabled.

This commit disables it, therefore the app does not have any way to
avoid a DDos attacks where clients just open connections without making
any request.
@josecelano
Merge #954: Disable TimeoutAcceptor when TSL is enabled
7ac1556 
222fa42 feat: disable TimeoutAcceptor when TSL is enabled (Jose Celano)

Pull request description:

  The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput for making a request after openning a connection.

  It does not work when TSL is enabled.

  This commit disables it, therefore the app does not have any way to avoid a DDos attacks where clients just open connections without making any request.

ACKs for top commit:
  josecelano:
    ACK 222fa42

Tree-SHA512: 0c9a01757f8683f19553ba332551103598c0d0483e3ec6ba1bae1e703acae84442c765883f7406bdb886bdeb5872780336d75450736350e7ce9d859e9943e0bb
@josecelano
fix: benchmarking config template
e563bfb 
- Missing [core.tracker_policy] section. Configuration was changed.
- Missing database config. Needed when the default DB folder does not
  exist. With this config storage folder is not needed. WE are not using
DB which required DB for benchmarking.
@josecelano
Merge #1001: fix: benchmarking config template
bd5f4e8 
e563bfb fix: benchmarking config template (Jose Celano)

Pull request description:

  Fix benchmarking config template:

  - Missing [core.tracker_policy] section. The configuration was changed.
  - Missing database config. Needed when the default DB folder does not exist. With this config, a storage folder is not needed. We are not using DB, which requires DB for benchmarking.

ACKs for top commit:
  josecelano:
    ACK e563bfb

Tree-SHA512: ca8e73e4416fd0f4af74f6b8c10987d8ed4d5b19b73dad1273af98c97796f93027b34e98827b6d65f9a6c9e171ce64c8b63ae70245c3a2b9535eddf5be3a2cbc
@josecelano
feat: [#1002] remove inactive peers always
1766587 
even when `remove_peerless_torrents` is disabled.

We should remove peer that haven't announce otherwise we are returning
inactive peers to the clients. That does not affect keeping the torrents
even if they don't have any peer.
@josecelano
refactor: [#1002] rename is_good fn to meets_retaining_policy
3fbab31 
A "good" torrent means it should be retained in the repository according
to the tracker policy. It should not be removed (even if it does not
have any peers).
@josecelano
Merge #1003: Fix bug: the tracker should always remove inactive peers
eaa86a7 
3fbab31 refactor: [#1002] rename is_good fn to meets_retaining_policy (Jose Celano)
1766587 feat: [#1002] remove inactive peers always (Jose Celano)

Pull request description:

  **Fix bug:** the tracker should always remove inactive peers even when the config option `core.tracker_policy.remove_peerless_torrents` is disabled.

  **Refactor:** rename the `is_good` function to `meets_retaining_policy` to be more specific.

ACKs for top commit:
  josecelano:
    ACK 3fbab31

Tree-SHA512: 765124c224e5328c3820417e7b1d53bcac4171bb5b7afb26c9c6bcf26c9792166502dde8381b22396924531bfe5f2b213f6be58ac20548fee3c872231861649e
@josecelano
feat!: [#1006] remove config deafults for secrets
f5e38bb
@josecelano
fix: linter errors
6a707b9
@josecelano
Merge #1007: Remove default configuration values for secrets
f6bbcf5 
6a707b9 fix: linter errors (Jose Celano)
f5e38bb feat!: [#1006] remove config  deafults for secrets (Jose Celano)

Pull request description:

  Remove default configuration values for secrets. To avoid running the tracker unintentionally with known values.

ACKs for top commit:
  josecelano:
    ACK 6a707b9

Tree-SHA512: 4360ad36f97afcc21307d2f945ca73dc40ef08a96406c40ac4b9e856756e1b3ca0464b99e34b6843013bfb393d46ede618d49c000fdb386829a450b61d6e44f0
@josecelano
chore(deps): update dependencies
62ffffb 
```console
cargo update
    Updating crates.io index
     Locking 16 packages to latest compatible versions
    Updating async-io v2.3.3 -> v2.3.4
    Updating cc v1.1.7 -> v1.1.10
    Updating clap v4.5.13 -> v4.5.15
    Updating clap_builder v4.5.13 -> v4.5.15
    Updating core-foundation-sys v0.8.6 -> v0.8.7
    Updating hyper-util v0.1.6 -> v0.1.7
    Updating mio v1.0.1 -> v1.0.2
    Updating object v0.36.2 -> v0.36.3
    Updating piper v0.2.3 -> v0.2.4
    Updating polling v3.7.2 -> v3.7.3
    Updating rustls-pki-types v1.7.0 -> v1.8.0
    Updating serde v1.0.204 -> v1.0.206
    Updating serde_derive v1.0.204 -> v1.0.206
    Updating serde_json v1.0.122 -> v1.0.124
    Updating syn v2.0.72 -> v2.0.74
    Updating tempfile v3.11.0 -> v3.12.0
```
@josecelano
Merge #1008: Update dependencies
acb860f 
62ffffb chore(deps): update dependencies (Jose Celano)

Pull request description:

  Update dependencies:

  ```console
  cargo update
      Updating crates.io index
       Locking 16 packages to latest compatible versions
      Updating async-io v2.3.3 -> v2.3.4
      Updating cc v1.1.7 -> v1.1.10
      Updating clap v4.5.13 -> v4.5.15
      Updating clap_builder v4.5.13 -> v4.5.15
      Updating core-foundation-sys v0.8.6 -> v0.8.7
      Updating hyper-util v0.1.6 -> v0.1.7
      Updating mio v1.0.1 -> v1.0.2
      Updating object v0.36.2 -> v0.36.3
      Updating piper v0.2.3 -> v0.2.4
      Updating polling v3.7.2 -> v3.7.3
      Updating rustls-pki-types v1.7.0 -> v1.8.0
      Updating serde v1.0.204 -> v1.0.206
      Updating serde_derive v1.0.204 -> v1.0.206
      Updating serde_json v1.0.122 -> v1.0.124
      Updating syn v2.0.72 -> v2.0.74
      Updating tempfile v3.11.0 -> v3.12.0
  ```

ACKs for top commit:
  josecelano:
    ACK 62ffffb

Tree-SHA512: cae2b0c44238998fa5acfc43b6f930ac89a8e242fc54ddd075628431bca69bf4debcb27241fd59a21b282bdc559e0d8fe13bd70d3d965afd4d7929c833a3449d
@josecelano josecelano requested a review from a team as a code owner August 12, 2024 16:06
@josecelano josecelano requested a review from da2ce7 August 12, 2024 16:06
@josecelano josecelano force-pushed the staging/main branch 2 times, most recently from 0f9dadc to e81ba06 Compare August 12, 2024 16:11
@josecelano josecelano marked this pull request as draft August 12, 2024 16:33
@josecelano
Copy link
Member Author

This PR must be updated because of some missing packages in the deployment workflow.

@josecelano
Merge #1011: Fix missing publishing packages
05b6cc8 
1455295 ci: [#1010] fix missing publishing packages (Jose Celano)

Pull request description:

  Fix missing publishing packages.

ACKs for top commit:
  josecelano:
    ACK 1455295

Tree-SHA512: 75a6700aaebaae0b1592143d265833e38acef80c618862fbaae106c80d4a8367569cffdd325eda42edac5578aaa77fc9da9ba6f8dc15e52f5e1fda0d21e9d557
@josecelano josecelano marked this pull request as ready for review August 13, 2024 09:31
@josecelano josecelano merged commit 78b8be8 into main Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josecelano @hungfnt @da2ce7 @GGLinnk @mario-nt