Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Fix warning #717

Closed
wants to merge 2 commits into from
Closed

util: Fix warning #717

wants to merge 2 commits into from

Conversation

zhao-gang
Copy link

Fixed following warning:

warning: use of deprecated associated function futures_util::stream::FuturesOrdered::<Fut>::push: use push_back instead
--> tower/src/util/call_all/ordered.rs:171:25
|
171 | FuturesOrdered::push(self, future)
| ^^^^
|
= note: #[warn(deprecated)] on by default

warning: tower (lib) generated 1 warning

Fixed following warning:

warning: use of deprecated associated function `futures_util::stream::FuturesOrdered::<Fut>::push`: use `push_back` instead
   --> tower/src/util/call_all/ordered.rs:171:25
    |
171 |         FuturesOrdered::push(self, future)
    |                         ^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: `tower` (lib) generated 1 warning
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco
Copy link
Member

Seems to be a snag on ci related to msrv, once that is fixed we can merge.

@wafuwafu13
Copy link

wafuwafu13 commented May 16, 2023

related #735

push_back is released in v0.3.22, but CI checks v0.3.11

@tobz
Copy link
Member

tobz commented Jul 20, 2024

Closing this as it needs a bump to use futures-util 0.3.22, and it doesn't seem like I have write permission to update the existing branch.

@tobz tobz closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants