Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use FuturesOrdered::push_back instead of FuturesOrdered::push #735

Closed
wants to merge 1 commit into from

Conversation

wafuwafu13
Copy link

GitHub Actions / check-stable says " use of deprecated method futures_util::stream::FuturesOrdered::<Fut>::push: use push_back instead ".

ref: https://docs.rs/futures/latest/futures/stream/struct.FuturesOrdered.html

pub fn push(&mut self, future: Fut)
👎Deprecated: use push_back instead

@wafuwafu13
Copy link
Author

push_back is released v0.3.22
rust-lang/futures-rs#2632

https://github.com/tower-rs/tower/actions/runs/4996600562/jobs/8950079959?pr=735

Checking futures v0.3.11
error[E0599]: no function or associated item named `push_back` found for struct `FuturesOrdered<_>` in the current scope
Error:    --> tower/src/util/call_all/ordered.rs:171:25
    |
171 |         FuturesOrdered::push_back(self, future)
    |                         ^^^^^^^^^ function or associated item not found in `FuturesOrdered<_>

@wafuwafu13 wafuwafu13 closed this May 16, 2023
@wafuwafu13 wafuwafu13 mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant