-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor songtag LRC handling #384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is completely unused
fixup: rename variables
as its only used once, all other places have it inlined already
…the full millis also no modulation for millis
nested formatting without intermediate allocations!
…instead of indexing
also no heap allocations
…instead of Result<_, ()>
…tions and checking also reverse "sort_by" variable names
… less cloning for lyric frames
instead of removing, shifting, shifting again and adding.
Change so that "get_index" does not add 2seconds to the time, if it is still wanted, the caller should do it. Also change input to be milliseconds
instead of inverting
…ble" message on same value instead of "on no lyric frames" and later use "parsed lyrics"
instead of getting seconds, then converting to milliseconds
I did some more changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors many parts of the
lib::songtag::lrc
module and touches upon some related lyric things, in more details: